Open sjuxax opened 1 year ago
demoulinv
commented
1 year ago Hello, One question, what kind of image do you try to import ? And one remark, Meshroom/AliceVision do not support lensfun but you specify a lensfun file for lens distortion correction. What happens if you don't specify anything ?
sjuxax
commented
1 year ago This is an image taken from my phone's camera that imported successfully on a build from back in August. It seems to throw the error on every image I've tried, though.
Nothing changes with the LensFun file either there or not; I added it as a last-ditch attempt to get something that worked.
demoulinv
commented
1 year ago Difficult to give you some cues without knowing which hacks you had to add to get AliceVision to build.
sjuxax
commented
1 year ago This is my current git diff from develop:
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 8fcdd6731..b3f4b8432 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -445,14 +445,22 @@ endif()
# Flann
# ==============================================================================
if(ALICEVISION_BUILD_SFM)
- find_package(lz4 REQUIRED)
+ find_package(PkgConfig REQUIRED)
+ # find_package(lz4 REQUIRED)
find_package(flann REQUIRED)
- if (TARGET lz4::lz4)
- set(FLANN_LIBRARIES flann::flann_cpp lz4::lz4)
- elseif (TARGET LZ4::lz4_static)
+
+
+ message(STATUS "LZ4 via pkgconfig")
+ find_package(PkgConfig REQUIRED)
+ pkg_check_modules(LZ4 REQUIRED IMPORTED_TARGET GLOBAL liblz4)
+ link_libraries(PkgConfig::LZ4)
+
+ if (TARGET PkgConfig::LZ4)
+ set(FLANN_LIBRARIES flann::flann_cpp PkgConfig::LZ4)
+ elseif (TARGET PkgConfig::LZ4::lz4_static)
set(FLANN_LIBRARIES flann::flann_cpp LZ4::lz4_static)
- elseif (TARGET LZ4::lz4_shared)
+ elseif (TARGET PkgConfig::LZ4::lz4_shared)
set(FLANN_LIBRARIES flann::flann_cpp LZ4::lz4_shared)
else()
message(FATAL_ERROR "FLANN can not be found")
@@ -463,9 +471,11 @@ endif()
# CoinUtils, Clp, Osi
# ==============================================================================
if(ALICEVISION_BUILD_SFM)
- find_package(CoinUtils REQUIRED)
- find_package(Clp REQUIRED)
- find_package(Osi REQUIRED)
+ find_package(PkgConfig REQUIRED)
+ pkg_check_modules(CoinUtils REQUIRED IMPORTED_TARGET GLOBAL coinutils)
+ pkg_check_modules(Clp REQUIRED IMPORTED_TARGET GLOBAL clp)
+ pkg_check_modules(Osi REQUIRED IMPORTED_TARGET GLOBAL osi)
+ pkg_check_modules(OsiClp REQUIRED IMPORTED_TARGET GLOBAL osi-clp)
endif()
@@ -872,7 +882,7 @@ else()
set(SPHINX_HTML_DIR "${CMAKE_CURRENT_BINARY_DIR}/htmlDoc")
configure_file(
- "${CMAKE_CURRENT_SOURCE_DIR}/../docs/sphinx/rst/conf.py"
+ "${CMAKE_CURRENT_SOURCE_DIR}/../docs/sphinx/conf.py"
"${CMAKE_CURRENT_BINARY_DIR}/conf.py"
@ONLY
)
@@ -880,7 +890,7 @@ else()
add_custom_target(doc ALL
${SPHINX_EXECUTABLE}
-b html
- "${CMAKE_CURRENT_SOURCE_DIR}/../docs/sphinx/rst"
+ "${CMAKE_CURRENT_SOURCE_DIR}/../docs/sphinx"
"${SPHINX_HTML_DIR}"
COMMENT "Building HTML documentation with Sphinx")
diff --git a/src/aliceVision/linearProgramming/CMakeLists.txt b/src/aliceVision/linearProgramming/CMakeLists.txt
index bc4401273..f15c369b1 100644
--- a/src/aliceVision/linearProgramming/CMakeLists.txt
+++ b/src/aliceVision/linearProgramming/CMakeLists.txt
@@ -10,9 +10,10 @@ set(linearProgramming_files_headers
set(aliceVision_linearProgramming_DEPS
aliceVision_numeric
aliceVision_system
- Coin::Clp # clp + solver wrapper
- Coin::CoinUtils # container tools
- Coin::Osi # generic LP
+ PkgConfig::Clp # clp + solver wrapper
+ PkgConfig::CoinUtils # container tools
+ PkgConfig::Osi # generic LP
+ PkgConfig::OsiClp # some symbols needed
)
if (NOT MOSEK_FOUND)
diff --git a/src/cmake/AliceVisionConfig.cmake.in b/src/cmake/AliceVisionConfig.cmake.in
index 5106ab2bb..91be55cfb 100644
--- a/src/cmake/AliceVisionConfig.cmake.in
+++ b/src/cmake/AliceVisionConfig.cmake.in
@@ -105,9 +105,11 @@ endif()
set(ALICEVISION_BUILD_SFM @ALICEVISION_BUILD_SFM@)
if(ALICEVISION_BUILD_SFM)
- find_dependency(CoinUtils REQUIRED)
- find_dependency(Clp REQUIRED)
- find_dependency(Osi REQUIRED)
+ find_package(PkgConfig REQUIRED)
+ pkg_check_modules(CoinUtils REQUIRED IMPORTED_TARGET coinutils)
+ pkg_check_modules(Clp REQUIRED IMPORTED_TARGET clp)
+ pkg_check_modules(Osi REQUIRED IMPORTED_TARGET osi)
+ pkg_check_modules(OsiClp REQUIRED IMPORTED_TARGET osi-clp)
endif()
set(ALICEVISION_BUILD_MVS @ALICEVISION_BUILD_MVS@)
diff --git a/src/cmake/OptimizeForArchitecture.cmake b/src/cmake/OptimizeForArchitecture.cmake
index 89a2e9f2b..8d8b04846 100644
--- a/src/cmake/OptimizeForArchitecture.cmake
+++ b/src/cmake/OptimizeForArchitecture.cmake
@@ -139,6 +139,8 @@ macro(OFA_AutodetectX86)
set(TARGET_ARCHITECTURE "cannonlake")
elseif(_cpu_model EQUAL 142 OR _cpu_model EQUAL 158) # 8E, 9E
set(TARGET_ARCHITECTURE "kaby-lake")
+ elseif(_cpu_model EQUAL 151) # 8E, 9E
+ set(TARGET_ARCHITECTURE "alderlake")
elseif(_cpu_model EQUAL 85) # 55
set(TARGET_ARCHITECTURE "skylake-avx512")
elseif(_cpu_model EQUAL 78 OR _cpu_model EQUAL 94 OR _cpu_model EQUAL 165) # 4E, 5E
@@ -268,6 +270,10 @@ macro(OFA_HandleX86Options)
_skylake_avx512()
list(APPEND _available_vector_units_list "avx512ifma" "avx512vbmi")
endmacro()
+ macro(_alderlake)
+ list(APPEND _march_flag_list "alderlake")
+ _skylake()
+ endmacro()
macro(_knightslanding)
list(APPEND _march_flag_list "knl")
_broadwell()
@@ -311,6 +317,8 @@ macro(OFA_HandleX86Options)
_skylake_avx512()
elseif(TARGET_ARCHITECTURE STREQUAL "skylake")
_skylake()
+ elseif(TARGET_ARCHITECTURE STREQUAL "alderlake")
+ _alderlake()
elseif(TARGET_ARCHITECTURE STREQUAL "broadwell")
_broadwell()
elseif(TARGET_ARCHITECTURE STREQUAL "haswell")
@@ -580,7 +588,7 @@ Other supported values are: \"none\", \"generic\", \"core\", \"merom\" (65nm Cor
\"haswell\", \"broadwell\", \"skylake\", \"skylake-xeon\", \"kaby-lake\", \"cannonlake\", \"silvermont\", \
\"goldmont\", \"knl\" (Knights Landing), \"atom\", \"k8\", \"k8-sse3\", \"barcelona\", \
\"istanbul\", \"magny-cours\", \"bulldozer\", \"interlagos\", \"piledriver\", \
-\"AMD 14h\", \"AMD 16h\", \"zen\".")
+\"AMD 14h\", \"AMD 16h\", \"zen\", \"alderlake\".")
elseif("${CMAKE_SYSTEM_PROCESSOR}" MATCHES "(arm|aarch32|aarch64)")
set(TARGET_ARCHITECTURE "auto" CACHE STRING "CPU architecture to optimize for. \
Using an incorrect setting here can result in crashes of the resulting binary because of invalid instructions used. \
diff --git a/src/dependencies/nanoflann b/src/dependencies/nanoflann
--- a/src/dependencies/nanoflann
+++ b/src/dependencies/nanoflann
@@ -1 +1 @@
-Subproject commit f1e47f0dbae72c11b008fd0d5b1191d9ba1f29bb
+Subproject commit f1e47f0dbae72c11b008fd0d5b1191d9ba1f29bb-dirty
diff --git a/src/software/utils/CMakeLists.txt b/src/software/utils/CMakeLists.txt
index a10ef7298..13071c821 100644
--- a/src/software/utils/CMakeLists.txt
+++ b/src/software/utils/CMakeLists.txt
@@ -255,9 +255,9 @@ if(ALICEVISION_BUILD_SFM)
aliceVision_sfmData
aliceVision_sfmDataIO
aliceVision_colorHarmonization
- Coin::Clp
- Coin::CoinUtils
- Coin::Osi
+ PkgConfig::Clp
+ PkgConfig::CoinUtils
+ PkgConfig::Osi
Boost::program_options
Boost::filesystem
Boost::boost
diff --git a/src/software/utils/main_computeUncertainty.cpp b/src/software/utils/main_computeUncertainty.cpp
index 23d2ab9ee..4f4c019a5 100644
--- a/src/software/utils/main_computeUncertainty.cpp
+++ b/src/software/utils/main_computeUncertainty.cpp
@@ -41,6 +41,8 @@ int aliceVision_main(int argc, char **argv)
std::string algorithm = cov::EAlgorithm_enumToString(cov::eAlgorithmSvdTaylorExpansion);
bool debug = false;
+ std::string verboseLevel = system::EVerboseLevel_enumToString(system::Logger::getDefaultVerboseLevel());
+ po::options_description params("Parameters");
params.add_options()
("input,i", po::value<std::string>(&sfmDataFilename)->required(),
"SfMData file to align.")It's mostly just setting up a few dependencies to use PkgConfig instead of cmake for resolution. I also hacked alderlake CPU support in there. This same patchset was used in earlier builds without issue.
sjuxax
commented
1 year ago Oh, I also have this in the nanoflann submodule:
diff --git a/examples/example_with_cmake/pointcloud_example.cpp b/examples/example_with_cmake/pointcloud_example.cpp
index ffe9062..f70b98b 100644
--- a/examples/example_with_cmake/pointcloud_example.cpp
+++ b/examples/example_with_cmake/pointcloud_example.cpp
@@ -62,7 +62,7 @@ void kdtree_demo(const size_t N)
nanoflann::KNNResultSet<num_t> resultSet(num_results);
resultSet.init(&ret_index, &out_dist_sqr);
index.findNeighbors(
- resultSet, &query_pt[0], nanoflann::SearchParams(10));
+ resultSet, &query_pt[0], nanoflann::SearchParameters(10));
std::cout << "knnSearch(nn=" << num_results << "): \n";
std::cout << "ret_index=" << ret_index
@@ -75,7 +75,7 @@ void kdtree_demo(const size_t N)
nanoflann::RadiusResultSet<num_t, size_t> resultSet(
radius, indices_dists);
- index.findNeighbors(resultSet, query_pt, nanoflann::SearchParams());
+ index.findNeighbors(resultSet, query_pt, nanoflann::SearchParameters());
// Get worst (furthest) point, without sorting:
std::pair<size_t, num_t> worst_pair = resultSet.worst_item();
diff --git a/examples/example_with_pkgconfig/pointcloud_example.cpp b/examples/example_with_pkgconfig/pointcloud_example.cpp
index ffe9062..f70b98b 100644
--- a/examples/example_with_pkgconfig/pointcloud_example.cpp
+++ b/examples/example_with_pkgconfig/pointcloud_example.cpp
@@ -62,7 +62,7 @@ void kdtree_demo(const size_t N)
nanoflann::KNNResultSet<num_t> resultSet(num_results);
resultSet.init(&ret_index, &out_dist_sqr);
index.findNeighbors(
- resultSet, &query_pt[0], nanoflann::SearchParams(10));
+ resultSet, &query_pt[0], nanoflann::SearchParameters(10));
std::cout << "knnSearch(nn=" << num_results << "): \n";
std::cout << "ret_index=" << ret_index
@@ -75,7 +75,7 @@ void kdtree_demo(const size_t N)
nanoflann::RadiusResultSet<num_t, size_t> resultSet(
radius, indices_dists);
- index.findNeighbors(resultSet, query_pt, nanoflann::SearchParams());
+ index.findNeighbors(resultSet, query_pt, nanoflann::SearchParameters());
// Get worst (furthest) point, without sorting:
std::pair<size_t, num_t> worst_pair = resultSet.worst_item();Wouldn't build without it, just blindly followed the compiler's suggestion of "Did you mean...".
fabiencastan
commented
1 year ago BTW, Could you submit the fixes as PRs? I mean:
- "${CMAKE_CURRENT_SOURCE_DIR}/../docs/sphinx/rst/conf.py"
+ "${CMAKE_CURRENT_SOURCE_DIR}/../docs/sphinx/conf.py"And the addition of new architectures in the cmake. (But we will not integrate the changes specific to PkgConfig in the cmake)
Could double check using the same image with the latest prebuilt release?
sjuxax
commented
11 months ago Latest prebuilt release doesn't start on my machine:
$ OCIO_CONFIG=/home/jeff/local/share/aliceVision/config.ocio ./Meshroom-2023.2.0-av3.1.0-centos7-cuda11.3.1/Meshroom
[2023-12-07 15:35:17.660040] [0x00007f4262074740] [error] Embedded OCIO configuration file: '/usr/share/aliceVision/config.ocio' cannot be accessed.
terminate called after throwing an instance of 'std::runtime_error'
what(): Embedded OCIO configuration file: '/usr/share/aliceVision/config.ocio' cannot be accessed.
fish: Job 1, 'OCIO_CONFIG=/home/jeff/local/sh…' terminated by signal SIGABRT (Abort)Still getting the original error with today's HEAD.
sjuxax
commented
11 months ago Get the same with images from https://gitlab.com/photogrammetry-test-sets/skull-cameramoves-weak-light-no-background .
BenjaminLesne
commented
9 months ago I just installed the meshroom arch package and I get the same issue
@sjuxax did you find a workaround?
I tried with images from these two repo
everything give the same error:
I just installed it on an other machine with windows, I used the same images and it works fine.
Also, shouldn't this issue be labeled as a bug? :thinking:
demoulinv
commented
9 months ago Hello, You have a warning about ALICEVISION_ROOT that is not defined. Did you have a try by setting ALICEVISION_ROOT to the folder where AliceVision is installed ?
BenjaminLesne
commented
9 months ago @demoulinv I tried to find the path to the aliveVision installation with the following command:
pacman -Ql alice-visionwhich gives me the following output :
I don't know really know what to do from there, which path should I use? I tried to add this random path from the logs in my .bashrc (and my PATH) without success:
export ALICEVISION_ROOT="/usr/bin"I suppose my main mistake was to use those pacman packages:
instead of :
It not so clear for me how I am supposed to install aliceVision
anselm-baur
commented
8 months ago Hi there, I'm using Linux Manjaro and I can confirm the same observation as @sjuxax I have a clean release installation via pacman. I tried to import the images from the https://github.com/alicevision/dataset_monstree repo.
Failed to Import Images - Meshroom 2023.3.0
You probably have a corrupted image within the images that you are trying to import.Here what I get in my terminal as output:
WARNING:root:== The following "submitters" plugins could not be loaded ==
* rippleSubmitter: No module named 'mpc'
* simpleFarmSubmitter: No module named 'simpleFarm'
[2024-03-17 22:09:52.436996] [0x00007ff4d57a16c0] [debug] Embedded OCIO config file in ALICEVISION_ROOT does not exist, use config from source code: /usr/share/aliceVision/config.ocio
[QtAliceVision] Plugin Initialized
[2024-03-17 22:10:18.893670] [0x00007f46698b7000] [debug] Embedded OCIO config file in ALICEVISION_ROOT does not exist, use config from source code: /usr/share/aliceVision/config.ocio
Program called with the following parameters:
* allowSingleView = 1
* allowedCameraModels = "pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld"
* colorProfileDatabase = "" (default)
* defaultCameraModel = "" (default)
* defaultFieldOfView = 45
* defaultFocalLength = -1 (default)
* defaultFocalRatio = 1 (default)
* defaultOffsetX = 0 (default)
* defaultOffsetY = 0 (default)
* errorOnMissingColorProfile = 1 (default)
* groupCameraFallback = Unknown Type "20EGroupCameraFallback"
* imageFolder = "" (default)
* input = "/tmp/tmpcdii22gv/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"
* lensCorrectionProfileInfo = ""
* lensCorrectionProfileSearchIgnoreCameraModel = 1
* maxCoresAvailable = Unknown Type "j" (default)
* maxMemoryAvailable = 18446744073709551615 (default)
* output = "/tmp/tmpcdii22gv/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm"
* rawColorInterpretation = Unknown Type "N11aliceVision5image23ERawColorInterpretationE"
* sensorDatabase = ""
* verboseLevel = "info"
* viewIdMethod = Unknown Type "N11aliceVision9sfmDataIO13EViewIdMethodE"
* viewIdRegex = ".*?(\d+)" (default)
Hardware :
Detected core count : 16
OpenMP will use 16 cores
Detected available memory : 24993 Mo
[22:10:18.899636][error] Invalid input sensor database '/usr/share/aliceVision/share/aliceVision/cameraSensors.db', please specify a valid file.
ERROR:root:Error while building intrinsics: CameraInit failed with error code 1.
Command was: "aliceVision_cameraInit --sensorDatabase "${ALICEVISION_SENSOR_DB}" --lensCorrectionProfileInfo "${ALICEVISION_LENS_PROFILE_INFO}" --lensCorrectionProfileSearchIgnoreCameraModel True --defaultFieldOfView 45.0 --groupCameraFallback folder --allowedCameraModels pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld --rawColorInterpretation LibRawWhiteBalancing --viewIdMethod metadata --verboseLevel info --output "/tmp/tmpcdii22gv/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm" --allowSingleView 1 --input "/tmp/tmpcdii22gv/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"".
QQmlComponent: Created graphical object was not placed in the graphics scene.I also tried to set the ALICEVISION_ROOT environment variable to /usr/share/aliceVision and specified a cameraSensors.db which I downloaded from github. And I threw out the lense profile correction and I still end up with kinda the same error.
This gave me
[2024-03-17 22:22:47.062259] [0x00007f40e025b000] [debug] Embedded OCIO config file in ALICEVISION_ROOT does not exist, use config from source code: /usr/share/aliceVision/config.ocio
Program called with the following parameters:
* allowSingleView = 1
* allowedCameraModels = "pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld"
* colorProfileDatabase = "" (default)
* defaultCameraModel = "" (default)
* defaultFieldOfView = 45
* defaultFocalLength = -1 (default)
* defaultFocalRatio = 1 (default)
* defaultOffsetX = 0 (default)
* defaultOffsetY = 0 (default)
* errorOnMissingColorProfile = 1 (default)
* groupCameraFallback = Unknown Type "20EGroupCameraFallback"
* imageFolder = "" (default)
* input = "/tmp/tmpkuml9cwa/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"
* lensCorrectionProfileInfo = ""
* lensCorrectionProfileSearchIgnoreCameraModel = 1
* maxCoresAvailable = Unknown Type "j" (default)
* maxMemoryAvailable = 18446744073709551615 (default)
* output = "/tmp/tmpkuml9cwa/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm"
* rawColorInterpretation = Unknown Type "N11aliceVision5image23ERawColorInterpretationE"
* sensorDatabase = "/path/to/my/cameraSensors.db"
* verboseLevel = "info"
* viewIdMethod = Unknown Type "N11aliceVision9sfmDataIO13EViewIdMethodE"
* viewIdRegex = ".*?(\d+)" (default)
Hardware :
Detected core count : 16
OpenMP will use 16 cores
Detected available memory : 24936 Mo
terminate called after throwing an instance of 'std::out_of_range'
what(): Invalid distortion model for pinhole camera.
ERROR:root:Error while building intrinsics: CameraInit failed with error code -6.
Command was: "aliceVision_cameraInit --sensorDatabase "/path/to/my/cameraSensors.db" --lensCorrectionProfileInfo "" --lensCorrectionProfileSearchIgnoreCameraModel True --defaultFieldOfView 45.0 --groupCameraFallback folder --allowedCameraModels pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld --rawColorInterpretation LibRawWhiteBalancing --viewIdMethod metadata --verboseLevel info --output "/tmp/tmpkuml9cwa/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm" --allowSingleView 1 --input "/tmp/tmpkuml9cwa/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"".
QQmlComponent: Created graphical object was not placed in the graphics scene.Hello, AliceVision seems to be installed directly at the user level. In that config, the ALICEVISION_ROOT environment variable should just be set to /usr
anselm-baur
commented
8 months ago Hi @demoulinv ,
I tried with export ALICEVISION_ROOT=/usr and it is still not working:
export ALICEVISION_ROOT=/usr
$ meshroom
WARNING:root:== The following "submitters" plugins could not be loaded ==
* rippleSubmitter: No module named 'mpc'
* simpleFarmSubmitter: No module named 'simpleFarm'
[2024-03-18 19:26:19.399077] [0x00007f79e6ffd6c0] [trace] Embedded OCIO configuration file: '/usr/share/aliceVision/config.ocio' found.
[QtAliceVision] Plugin Initialized
[2024-03-18 19:26:51.597646] [0x00007f7e3499b000] [trace] Embedded OCIO configuration file: '/usr/share/aliceVision/config.ocio' found.
Program called with the following parameters:
* allowSingleView = 1
* allowedCameraModels = "pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld"
* colorProfileDatabase = "" (default)
* defaultCameraModel = "" (default)
* defaultFieldOfView = 45
* defaultFocalLength = -1 (default)
* defaultFocalRatio = 1 (default)
* defaultOffsetX = 0 (default)
* defaultOffsetY = 0 (default)
* errorOnMissingColorProfile = 1 (default)
* groupCameraFallback = Unknown Type "20EGroupCameraFallback"
* imageFolder = "" (default)
* input = "/tmp/tmpk72kjg2f/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"
* lensCorrectionProfileInfo = ""
* lensCorrectionProfileSearchIgnoreCameraModel = 1
* maxCoresAvailable = Unknown Type "j" (default)
* maxMemoryAvailable = 18446744073709551615 (default)
* output = "/tmp/tmpk72kjg2f/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm"
* rawColorInterpretation = Unknown Type "N11aliceVision5image23ERawColorInterpretationE"
* sensorDatabase = ""
* verboseLevel = "info"
* viewIdMethod = Unknown Type "N11aliceVision9sfmDataIO13EViewIdMethodE"
* viewIdRegex = ".*?(\d+)" (default)
Hardware :
Detected core count : 16
OpenMP will use 16 cores
Detected available memory : 29853 Mo
terminate called after throwing an instance of 'std::out_of_range'
what(): Invalid distortion model for pinhole camera.
ERROR:root:Error while building intrinsics: CameraInit failed with error code -6.
Command was: "aliceVision_cameraInit --sensorDatabase "${ALICEVISION_SENSOR_DB}" --lensCorrectionProfileInfo "${ALICEVISION_LENS_PROFILE_INFO}" --lensCorrectionProfileSearchIgnoreCameraModel True --defaultFieldOfView 45.0 --groupCameraFallback folder --allowedCameraModels pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld --rawColorInterpretation LibRawWhiteBalancing --viewIdMethod metadata --verboseLevel info --output "/tmp/tmpk72kjg2f/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm" --allowSingleView 1 --input "/tmp/tmpk72kjg2f/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"".
QQmlComponent: Created graphical object was not placed in the graphics scene.I also tried again with setting the sensorDatabase, same error.
demoulinv
commented
8 months ago Hi @anselm-baur,
Setting the ALICEVISION_ROOT environment variable to /usr is correct. At the beginning of your log, you can see that, unlike before, the ocio configuration file was found as expected.
Now you can try to set the sensorDatabase with:
export sensorDatabase=$ALICEVISION_ROOT/share/aliceVision/cameraSensors.db
anselm-baur
commented
8 months ago Hi @demoulinv
I tried also setting the sensorDatabase variable. At least the
terminate called after throwing an instance of 'std::out_of_range'
what(): Invalid distortion model for pinhole camera.tunred into:
terminate called after throwing an instance of 'std::out_of_range'
terminate called recursivelyhere the full output:
$ export ALICEVISION_ROOT=/usr
$ export sensorDatabase=$ALICEVISION_ROOT/share/aliceVision/cameraSensors.db
$ meshroom
WARNING:root:== The following "submitters" plugins could not be loaded ==
* rippleSubmitter: No module named 'mpc'
* simpleFarmSubmitter: No module named 'simpleFarm'
[2024-03-19 19:04:58.686959] [0x00007fb19a42b6c0] [trace] Embedded OCIO configuration file: '/usr/share/aliceVision/config.ocio' found.
[QtAliceVision] Plugin Initialized
[2024-03-19 19:05:20.613027] [0x00007fa7e32b0000] [trace] Embedded OCIO configuration file: '/usr/share/aliceVision/config.ocio' found.
Program called with the following parameters:
* allowSingleView = 1
* allowedCameraModels = "pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld"
* colorProfileDatabase = "" (default)
* defaultCameraModel = "" (default)
* defaultFieldOfView = 45
* defaultFocalLength = -1 (default)
* defaultFocalRatio = 1 (default)
* defaultOffsetX = 0 (default)
* defaultOffsetY = 0 (default)
* errorOnMissingColorProfile = 1 (default)
* groupCameraFallback = Unknown Type "20EGroupCameraFallback"
* imageFolder = "" (default)
* input = "/tmp/tmp3w8og_w1/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"
* lensCorrectionProfileInfo = ""
* lensCorrectionProfileSearchIgnoreCameraModel = 1
* maxCoresAvailable = Unknown Type "j" (default)
* maxMemoryAvailable = 18446744073709551615 (default)
* output = "/tmp/tmp3w8og_w1/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm"
* rawColorInterpretation = Unknown Type "N11aliceVision5image23ERawColorInterpretationE"
* sensorDatabase = ""
* verboseLevel = "info"
* viewIdMethod = Unknown Type "N11aliceVision9sfmDataIO13EViewIdMethodE"
* viewIdRegex = ".*?(\d+)" (default)
Hardware :
Detected core count : 16
OpenMP will use 16 cores
Detected available memory : 29532 Mo
terminate called after throwing an instance of 'std::out_of_range'
terminate called recursively
ERROR:root:Error while building intrinsics: CameraInit failed with error code -6.
Command was: "aliceVision_cameraInit --sensorDatabase "${ALICEVISION_SENSOR_DB}" --lensCorrectionProfileInfo "${ALICEVISION_LENS_PROFILE_INFO}" --lensCorrectionProfileSearchIgnoreCameraModel True --defaultFieldOfView 45.0 --groupCameraFallback folder --allowedCameraModels pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld --rawColorInterpretation LibRawWhiteBalancing --viewIdMethod metadata --verboseLevel info --output "/tmp/tmp3w8og_w1/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm" --allowSingleView 1 --input "/tmp/tmp3w8og_w1/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"".
QQmlComponent: Created graphical object was not placed in the graphics scene.I also tried to set ALICEVISION_SENSOR_DB but this brings the
$ export ALICEVISION_SENSOR_DB=${ALICEVISION_ROOT}/share/aliceVision/cameraSensors.db
$ meshroom
[...]
* sensorDatabase = "/usr/share/aliceVision/cameraSensors.db"
[...]
terminate called after throwing an instance of 'std::out_of_range'
what(): Invalid distortion model for pinhole camera.
ERROR:root:Error while building intrinsics: CameraInit failed with error code -6.
Command was: "aliceVision_cameraInit --sensorDatabase "/usr/share/aliceVision/cameraSensors.db" --lensCorrectionProfileInfo "${ALICEVISION_LENS_PROFILE_INFO}" --lensCorrectionProfileSearchIgnoreCameraModel True --defaultFieldOfView 45.0 --groupCameraFallback folder --allowedCameraModels pinhole,radial1,radial3,brown,fisheye4,fisheye1,3deanamorphic4,3deradial4,3declassicld --rawColorInterpretation LibRawWhiteBalancing --viewIdMethod metadata --verboseLevel info --output "/tmp/tmpn6umf5jm/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/cameraInit.sfm" --allowSingleView 1 --input "/tmp/tmpn6umf5jm/CameraInit/961e54591174ec5a2457c66da8eadc0cb03d89ba/viewpoints.sfm"".error back.
demoulinv
commented
8 months ago Hi @anselm-baur ,
Sorry for the confusion. You're right when you set the environment variable ALICEVISION_SENSOR_DB instead of sensorDatabase. All parameters seem to be ok.
Which monster tree dataset do you use for testing, the full one, the mini6 or the mini3 ?
anselm-baur
commented
8 months ago Hi @demoulinv ,
no problem. I tried all: min3, mini6, and full.
I looked also in the aliceVision source code to see at which place the things break. The error is thrown at https://github.com/alicevision/AliceVision/blob/d2f8306935e992f27269c05f0571421f7bec289d/src/aliceVision/camera/Pinhole.cpp#L336 in the Pinhole::getType() method. But I still don't understand where this is called.
Poly2it
commented
1 month ago I am also experiencing this issue trying to run AliceVision built from source. The issue does not seem to be present or active in the official builds (Linux x64). Have anyone had any success resolving this?
Poly2it
commented
1 month ago I attempted to remove pinhole from the list of allowed camera models, but I am still getting the "terminate called recursively" error as well as a core dump.
Poly2it
commented
1 month ago I decided to take this to gdb:
...
Hardware :
Detected core count : 20
OpenMP will use 20 cores
Detected available memory : 26916 Mo
[New Thread 0x7fffe6200000 (LWP 1965409)]
[New Thread 0x7fffe5800000 (LWP 1965410)]
[New Thread 0x7fffe4e00000 (LWP 1965411)]
[New Thread 0x7fffdfe00000 (LWP 1965412)]
[New Thread 0x7fffdf400000 (LWP 1965413)]
[New Thread 0x7fffdea00000 (LWP 1965414)]
[New Thread 0x7fffde000000 (LWP 1965415)]
[New Thread 0x7fffdd600000 (LWP 1965416)]
[New Thread 0x7fffdcc00000 (LWP 1965417)]
[New Thread 0x7fffd3e00000 (LWP 1965418)]
[New Thread 0x7fffd3400000 (LWP 1965419)]
[New Thread 0x7fffd2a00000 (LWP 1965420)]
[New Thread 0x7fffd2000000 (LWP 1965421)]
[New Thread 0x7fffd1600000 (LWP 1965422)]
[New Thread 0x7fffd0c00000 (LWP 1965423)]
[New Thread 0x7fffc7e00000 (LWP 1965424)]
[New Thread 0x7fffc7400000 (LWP 1965425)]
[New Thread 0x7fffc6a00000 (LWP 1965426)]
[New Thread 0x7fffc6000000 (LWP 1965427)]
terminate called recursively
terminate called recursively
terminate called after throwing an instance of 'std::out_of_range'
what(): Invalid distortion model for pinhole camera.
Thread 1 "aliceVision_cam" received signal SIGABRT, Aborted.And here's the backtrace:
#0 0x00007ffff36877dc in __pthread_kill_implementation () from /nix/store/5adwdl39g3k9a2j0qadvirnliv4r7pwd-glibc-2.39-52/lib/libc.so.6
#1 0x00007ffff3635516 in raise () from /nix/store/5adwdl39g3k9a2j0qadvirnliv4r7pwd-glibc-2.39-52/lib/libc.so.6
#2 0x00007ffff361d935 in abort () from /nix/store/5adwdl39g3k9a2j0qadvirnliv4r7pwd-glibc-2.39-52/lib/libc.so.6
#3 0x00007ffff3abe22a in __gnu_cxx::__verbose_terminate_handler() () from /nix/store/jfilhsiqdgm4nks2z6labx3iq9qd077a-gcc-13.3.0-lib/lib/libstdc++.so.6
#4 0x00007ffff3abc20a in __cxxabiv1::__terminate(void (*)()) () from /nix/store/jfilhsiqdgm4nks2z6labx3iq9qd077a-gcc-13.3.0-lib/lib/libstdc++.so.6
#5 0x00007ffff3abb289 in __cxa_call_terminate () from /nix/store/jfilhsiqdgm4nks2z6labx3iq9qd077a-gcc-13.3.0-lib/lib/libstdc++.so.6
#6 0x00007ffff3abb996 in __gxx_personality_v0 () from /nix/store/jfilhsiqdgm4nks2z6labx3iq9qd077a-gcc-13.3.0-lib/lib/libstdc++.so.6
#7 0x00007ffff3cd6a59 in _Unwind_RaiseException_Phase2 () from /nix/store/jfilhsiqdgm4nks2z6labx3iq9qd077a-gcc-13.3.0-lib/lib/libgcc_s.so.1
#8 0x00007ffff3cd7181 in _Unwind_RaiseException () from /nix/store/jfilhsiqdgm4nks2z6labx3iq9qd077a-gcc-13.3.0-lib/lib/libgcc_s.so.1
#9 0x00007ffff3abc4ba in __cxa_throw () from /nix/store/jfilhsiqdgm4nks2z6labx3iq9qd077a-gcc-13.3.0-lib/lib/libstdc++.so.6
#10 0x00007ffff62fac4e in aliceVision::camera::Pinhole::getType() const [clone .cold] () from /nix/store/8gxsfkgw9idhgxgyfsgnh5imgk8r38wz-AliceVision-3.2.0/lib/libaliceVision_camera.so.3
#11 0x00007ffff630a455 in aliceVision::camera::IntrinsicBase::hashValue() const () from /nix/store/8gxsfkgw9idhgxgyfsgnh5imgk8r38wz-AliceVision-3.2.0/lib/libaliceVision_camera.so.3
#12 0x00000000004392d1 in aliceVision_main(int, char**) [clone ._omp_fn.1] ()
#13 0x00007ffff38bc4a3 in __kmp_api_GOMP_parallel_40_alias () from /nix/store/984023dydw4szxhcsykphp957jlvwgdy-openmp-18.1.8/lib/libomp.so
#14 0x000000000044190a in aliceVision_main(int, char**) ()
#15 0x000000000042887f in main ()@anselm-baur, you might be interested since you were looking for the call site earlier.
Poly2it
commented
1 month ago As far as I can tell, this issue is caused from trying to generate a hash for IntrinsicBase.
https://github.com/alicevision/AliceVision/blob/d2f8306935e992f27269c05f0571421f7bec289d/src/aliceVision/camera/IntrinsicBase.cpp#L81
getType is called on PinHole, which in the 2023.3.0 distribution of Meshroom contains the following logic:
https://github.com/alicevision/AliceVision/blob/d2f8306935e992f27269c05f0571421f7bec289d/src/aliceVision/camera/Pinhole.cpp#L313
It might be valuable to note that this function has been simplified in the development version of AliceVision: https://github.com/alicevision/AliceVision/blob/1d5b5c524efe16119d1414395ddd14b62ef8134b/src/aliceVision/camera/Pinhole.cpp#L313
It now always returns EINTRINSIC::PINHOLE_CAMERA.
@servantftechnicolor modified this behaviour in https://github.com/alicevision/AliceVision/commit/3d8d19b90f96266f537a2f02a0472eaef851f02a (https://github.com/alicevision/AliceVision/pull/1680).
Poly2it
commented
1 month ago I forced AliceVision to not throw an error, and return EINTRINSIC::PINHOLE_CAMERA for non-matches:
diff --git a/src/aliceVision/camera/Pinhole.cpp b/src/aliceVision/camera/Pinhole.cpp
index ed1498ab3..9d45329d3 100644
--- a/src/aliceVision/camera/Pinhole.cpp
+++ b/src/aliceVision/camera/Pinhole.cpp
@@ -333,7 +333,7 @@ EINTRINSIC Pinhole::getType() const
case EDISTORTION::DISTORTION_3DEANAMORPHIC4:
return EINTRINSIC::PINHOLE_CAMERA_3DEANAMORPHIC4;
default:
- throw std::out_of_range("Invalid distortion model for pinhole camera.");
+ return EINTRINSIC::PINHOLE_CAMERA;
}
}
@@ -344,7 +344,7 @@ EINTRINSIC Pinhole::getType() const
case EDISTORTION::DISTORTION_3DEANAMORPHIC4:
return EINTRINSIC::PINHOLE_CAMERA_3DEANAMORPHIC4;
default:
- throw std::out_of_range("Invalid undistortion model for pinhole camera.");
+ return EINTRINSIC::PINHOLE_CAMERA;
}
}
I would not expect this to resolve the issue.
This yields a new error, which to my knowledge should not be able to occur with the Monstree dataset I am testing with:
[New Thread 0x7fffe6200000 (LWP 2025839)]
...
[New Thread 0x7fffc6a00000 (LWP 2025856)]
[16:28:45.825439][warning] Some image(s) have no serial number to identify the camera/lens device.
This makes it impossible to correctly group the images by device if you have used multiple identical (same model) camera devices.
The reconstruction will assume that only one device has been used, so if 2 images share the same focal length approximation they will share the same internal camera parameters.
3 image(s) are concerned.
[16:28:45.825463][error] At least one image should have an initialized intrinsic.
Check your input images metadata (brand, model, focal length, ...), more should be set and correct.
[Thread 0x7fffe6200000 (LWP 2025839) exited]
...
[Thread 0x7fffc6a00000 (LWP 2025856) exited]
[Inferior 1 (process 2025836) exited with code 01]It would be helpful to see the exact build instructions, revision and potential patches used for the binary distribution.
Poly2it
commented
1 month ago @fabiencastan should this issue be moved to AliceVision?
I'm getting this output when I try to import an image into Meshroom with a fresh build of AliceVision. This worked last time I built back in August, so I don't think it's an issue with the inputs.
Had to add several hacks to get it to build, so pretty sure it's something on my end, but not sure where to look. Any help is appreciated.