alicevision / Meshroom

3D Reconstruction Software
http://alicevision.org
Other
11.1k stars 1.08k forks source link

Three suggestions #296

Open ScottMcNay opened 5 years ago

ScottMcNay commented 5 years ago

Three suggestions:

  1. It's not always entirely clear when an error has happened, especially when the screen is across the room. How about a popup message?

  2. Does AliceVision/Meshroom handle motion between images, such as wind, people, traffic? If not, can I suggest an option to mark the parts of each image which should be ignored for matching purposes, and/or an option to manually suggest match points, perhaps by manually arranging some of the photos spatially?

  3. It's not always clear what the error messages mean in practical terms, and that's assuming it's even clear what the actual message is. For example, I'm getting two at the same time:

    • ERROR:root:Error on node computation: Error on node "StructureFromMotion_1":
    • ERROR:root:Error during Graph execution Error on node "StructureFromMotion_1": ...which I suspect is telling me it's unable to match the photos together because there's too many degrees of separation between photos and/or because there's not enough photos. Suggestion, have error messages open GitHub and automatically search for the message; if there's only one, go to it, while if there's no match, create a new issue with sample text (with environment info) prefilled. Maybe offer to include the log, with file paths and filenames anonymized. Thus, if the message has already been reported and a good answer provided, great. Otherwise, you might get people going to podunk.com to post their questions.
natowi commented 5 years ago

1) Good idea, maybe in combination with #268

2) Masking is on the to do list. Maybe masking out moving objects would be useful

3) Error messages will be improved over time

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.