search

alicevision / geogram

Git mirror of the geogram library by INRIA
https://github.com/BrunoLevy/geogram
BSD 3-Clause "New" or "Revised" License
123 stars 54 forks source link

Mac OS X / Clang: no _mm_set_pd1 definition #4

Closed ryanfb closed 6 years ago

ryanfb commented 6 years ago

See here: https://github.com/Homebrew/homebrew-core/pull/31094#discussion_r210025155

If compiling without changes on OS X, I get the error:

geogram_1.6.6/src/lib/geogram/numerics/predicates.cpp:341:20: error: use of undeclared identifier '_mm_set_pd1'; did you mean '_mm_set_ps1'?

From this StackOverflow answer, I found the apparent actual equivalent in Clang is _mm_set1_pd. Apparently Intel's implementation has #define _mm_set_pd1 _mm_set1_pd, so it may be possible to simply replace the one instance of _mm_set_pd1 with _mm_set1_pd.

What's the appropriate contact for getting this change made upstream?

simogasp commented 6 years ago

You can drop a mail to geogram-users@lists.gforge.inria.fr This is just a mirror of the original project

ryanfb commented 6 years ago

Thanks! Looks like it's amenable to upstream fixing: https://lists.gforge.inria.fr/pipermail/geogram-users/2018-August/000158.html