search

alichtman / shallow-backup

Git-integrated backup tool for macOS and Linux devs.
MIT License
1.21k stars 248 forks source link

Windows Compatibility #77

Open saadmanrafat opened 5 years ago

saadmanrafat commented 5 years ago

I was wondering if this could be extended to work on Windows.

alichtman commented 5 years ago

Yeah, this isn't limited to just macOS, but it would require a bunch of refactoring and testing that just isn't a priority of mine since I don't use Windows. I'm definitely open to a PR, though.

alichtman commented 5 years ago

Implementation Plan

Is this it?

saadmanrafat commented 5 years ago

Yes but another issue is inquirer, which doesn't work on Windows. Other viable choices are prompt_toolkit and Pyinquirer. Each has it's pros and cons. But using any one of them could lead to losing some features the repo already supports like the List prompt.

alichtman commented 5 years ago

One possibility is forking this project and maintaining a Windows version separately. I don't have the bandwidth to manage that, but I'd be open to someone else maintaining it.

alichtman commented 5 years ago

Another possibility is try / except importing inquirer and if that fails, import some other library that's Windows compatible. This is probably the best solution, as it would avoid forking the project. I still don't use Windows, though, so I won't be fixing this.

saadmanrafat commented 5 years ago

try except might work. I'll look into it.