alicialsims
commented
7 years ago Hey Shauvon,
Thank you so much for the feedback! And for all of your help these past months. I had a great time. I have a website at dreamhost - I'm going to look into some tutorials on running node there. I'd like to spend more time on this and add it to the portfolio.
Thank you again for all of your help! I really loved the in class project and debugging lessons. ((We never had in-class projects in my other cohorts
- BIG improvement!)) Maybe I will see you at JSLou!
On Thu, Mar 30, 2017 at 2:25 PM, Shauvon McGill notifications@github.com wrote:
Hey Alicia!
I just wanted to send you some notes on your project. It looks great and overall you have done a great job with the course. The simple styling is clean and efficient, and you have leveraged bootstrap well to put together a very usable interface. It clearly shows that you have an understanding of the MEAN stack and how to put an app together.
Here are a few things you could take a look at:
1.
You do have lots of console.logs throughout your code. That's totally fine, but you will want to get rid of those before you made this a "real" app somewhere. 2.
In your index.pug file, line 25, the '{{flerb.picUrl}}' is not being translated properly, resulting in an error in the browser console that 'localhost:8080/{{flerb.picUrl}}' was not found. You might have better luck (and fewer headaches) if you made the HTML for your angular app a separate file (a-la the in-class project). 3.
The "save" button is a little confusing when creating new items, plus it causes an error when you click it without first opening an item to edit. See if you can just have one button which switches between an "add" or a "save" button depending on what the user is doing. 4.
The placeholder text on your inputs gets cut off, which means the user can't necessarily read what goes in each field. You might consider making them labels above the input fields, or simply making the third field "Description" and use bootstrap tooltips to show more information.
I hope you enjoyed the class, and that this project was fun! I'm a big fan of the term "Flerb" so I hope you continue to work on it and add features. If you want to host it somewhere, you can take a look at Heroku (.com), which offers a free option to host a node app, and you can get a free add-on to serve up a MongoDB instance. Feel free to hit me (Shauvon) up on Slack if you have questions about that.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alicialsims/flerbs/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ALrUBokLvKGcLD-UxsIXzRutnIuFssLmks5rq_OlgaJpZM4MuvhF .
Hey Alicia!
I just wanted to send you some notes on your project. It looks great and overall you have done a great job with the course. The simple styling is clean and efficient, and you have leveraged bootstrap well to put together a very usable interface. It clearly shows that you have an understanding of the MEAN stack and how to put an app together.
Here are a few things you could take a look at:
You do have lots of console.logs throughout your code. That's totally fine, but you will want to get rid of those before you made this a "real" app somewhere.
In your index.pug file, line 25, the '{{flerb.picUrl}}' is not being translated properly, resulting in an error in the browser console that 'localhost:8080/{{flerb.picUrl}}' was not found. You might have better luck (and fewer headaches) if you made the HTML for your angular app a separate file (a-la the in-class project).
The "save" button is a little confusing when creating new items, plus it causes an error when you click it without first opening an item to edit. See if you can just have one button which switches between an "add" or a "save" button depending on what the user is doing.
The placeholder text on your inputs gets cut off, which means the user can't necessarily read what goes in each field. You might consider making them labels above the input fields, or simply making the third field "Description" and use bootstrap tooltips to show more information.
I hope you enjoyed the class, and that this project was fun! I'm a big fan of the term "Flerb" so I hope you continue to work on it and add features. If you want to host it somewhere, you can take a look at Heroku (.com), which offers a free option to host a node app, and you can get a free add-on to serve up a MongoDB instance. Feel free to hit me (Shauvon) up on Slack if you have questions about that.