alidcast / rogue.js

The "nearly invisible" way to server-render React applications
MIT License
1.89k stars 49 forks source link

Warnings about wrong versions #81

Open talentlessguy opened 5 years ago

talentlessguy commented 5 years ago

I ran this to install Rogue:

yarn add @roguejs/cli @roguejs/app react
react-dom react-router react-router-dom

But I already had some deps, such as react, react-dom and express. And during installing I got lots of messages about wrong versions / invalid engines.

My package.json before installation of Rouge:

"dependencies": {
    "express": "^4.16.4",
    "react": "^16.7.0",
    "react-dom": "^16.7.0"
  },
  "scripts": {
    "start": "node server/index.js"
  },
  "devDependencies": {
    "@babel/core": "^7.2.2",
    "@babel/plugin-proposal-class-properties": "^7.2.3",
    "@babel/plugin-transform-function-name": "^7.2.0",
    "@babel/preset-env": "^7.2.3",
    "@babel/preset-react": "^7.0.0",
    "npm-run-all": "^4.1.5"
  }
}

It seems that conflicts shouldn't appear. By the way in my terminal weird things happen:

warning @roguejs/cli > parcel-bundler > htmlnano > cssnano > postcss-merge-rules > browserslist@1.7.7: Browserslist 2 could fail on
reading Browserslist >3.0 config used in other tools.
warning @roguejs/cli > parcel-bundler > htmlnano > cssnano > postcss-merge-rules > caniuse-api > browserslist@1.7.7: Browserslist 2
could fail on reading Browserslist >3.0 config used in other tools.
warning @roguejs/app > loadable-components@2.2.3: Please use @loadable/component
warning @roguejs/app > react-native-web > deep-assign@3.0.0: Check out `lodash.merge` or `merge-options` instead.
⠄ @babel/plugin-syntax-nullish-coalescing-op⠁ babel-plugin-syntax-trailing-function-comm⠂ babel-plugin-syntax-trailing-function-comm[2/4] Fetching packages...
warning gitbook-plugin-prism@2.4.0: The engine "gitbook" appears to be invalid.
[3/4] Linking dependencies...
warning "@roguejs/app > react-native-web@0.9.13" has unmet peer dependency "react-art@>=16.5.1".
warning "@roguejs/app > react-native@0.57.8" has incorrect peer dependency "react@16.6.3".

I think some libraries used in Rogue are deprecated and absolete. Nothing crashes, but it isn't cool to see so many warnings during simple installation.

alidcast commented 5 years ago

yea just took a look, some dependencies are unused and should be removed - sorry about that.

also, rogue/cli is still early. make sure you're aware of #80 (hopefully parcel v2 will improve things).

talentlessguy commented 5 years ago

@alidcastano use yarn-check or npm-check CLI tool to automatically look up for obsolete dependencies so such issues won't popup anymore here. Also, why does your app need react-native inside browser? It is used for mobile devices or am I wrong?

Yarn check: https://www.npmjs.com/package/yarn-check

NPM Check: https://www.npmjs.com/package/npm-check