alidiepuit / osmtracker-android

Automatically exported from code.google.com/p/osmtracker-android
GNU General Public License v3.0
0 stars 0 forks source link

Open-keyboard / rotate phone event validates "note" #61

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Click on "notes" : a popup appears
2. Rotate your phone (or open the keyboard if any)
3. The popup disappears, and the note is recorded in .gpx.

What is the expected output? What do you see instead?
The popup should stay opened and not recorded.

What version of the product are you using (See "About" screen)?
0.43

Make/model of your device, and Android version?
Android 2.01, Motorola Milestone.

Please provide any additional information below.

Original issue reported on code.google.com by romain.v...@gmail.com on 8 Sep 2010 at 6:24

GoogleCodeExporter commented 9 years ago
Same here on T-Mobile G1 - Cyanogenmod6 (Android 2.2). I always get into 
clicking the note button (because I'm passing by a POI) and sliding the 
keyboard open makes the note disappear, but it actually recorded an empty note. 
Please leave the note open when opening the keyboard (or rotating the phone)

Original comment by emilien.klein on 23 Sep 2010 at 12:48

GoogleCodeExporter commented 9 years ago
I noticed this too. 
Technically, I believe that the issue is due android's handling of 
orientation/hardware changes. The current Activity is destroyed and new one 
created for the new configuration. 

A less jaring example of this phenomenon happens when you are on a button 
screen. when the phone is reoriented or the keyboard is opened, the view always 
reverts ack to the main button screen, regardless of the button layout that was 
visible before the orientation change. 

To preserve the feeling of a smooth transition, OSMTracker will need to keep 
track of the current state of the Activity and recreate that state when the new 
Activity i created for the orientation change.

A fix for this could consider a state preservation mechanism across all of the 
Activities in OSMTracker 

Original comment by oshea.p...@gmail.com on 28 Nov 2010 at 10:51

GoogleCodeExporter commented 9 years ago
Hi,

we should create the Text-Note Dialog within the TrackLogger activity, which 
should handle the state restore of the dialog box by itself. 
We need to check if the waypoint uuid is correctly restored.

http://developer.android.com/guide/topics/ui/dialogs.html#ShowingADialog
http://developer.android.com/guide/topics/resources/runtime-changes.html

best regards
Matthias

Original comment by matthias...@gmail.com on 29 Nov 2010 at 12:55

GoogleCodeExporter commented 9 years ago

Original comment by matthias...@gmail.com on 5 Dec 2010 at 6:04

GoogleCodeExporter commented 9 years ago
This is fixed in r252

Original comment by matthias...@gmail.com on 6 Dec 2010 at 12:23

GoogleCodeExporter commented 9 years ago
Sweet :)

Original comment by nicolas@guillaumin.me on 6 Dec 2010 at 8:05