alidiepuit / osmtracker-android

Automatically exported from code.google.com/p/osmtracker-android
GNU General Public License v3.0
0 stars 0 forks source link

Export directories created too often / too early #65

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Begin a new track, but don't yet hit "Start tracking"
2. Decide to not export this track

What is the expected output? What do you see instead?
Expected no change to the filesystem, but instead, an empty directory is 
created under osmtracker with the date & time of the track.  Eventually, 
several empty directories like this may be created.

What version of the product are you using (See "About" screen)?
current svn, based on 0.4.3

Make/model of your device, and Android version?
HTC Incredible, 2.1

Please provide any additional information below.

All the empty directories are clutter, and make it harder to browse to the GPX 
file you want.

I've attached a patch which waits for export time before creating the track's 
directory.

Original issue reported on code.google.com by jdmo...@nand.net on 18 Sep 2010 at 1:33

Attachments:

GoogleCodeExporter commented 9 years ago
Yeah I know creating the directory at the beginning isn't nice, but the problem 
is that we need to create the directory for saving Audio tags or Pictures.

Applying this patch as is will probably fail when recording audio or taking a 
picture.

Original comment by nguillau...@gmail.com on 19 Sep 2010 at 5:02

GoogleCodeExporter commented 9 years ago
I suppose checking for the existence of the export directory before doing 
anything on the SD card would be best-practice. Nothing prevents another app or 
the user himself to remove a directory while osmtracker is running, so you can 
not make the assumption this directory exists... (Even if in practice it will 
almost always be the case ;) )

Original comment by emilien.klein on 23 Sep 2010 at 12:25

GoogleCodeExporter commented 9 years ago
Good points.  Patch is now corrected to create the directory just before any 
point where it would be written to.  Based on current svn (r206).

Original comment by jdmo...@nand.net on 28 Sep 2010 at 10:42

Attachments:

GoogleCodeExporter commented 9 years ago
The work being done for issue #96 may provide the functionality required to 
resolve this issue.

- Paul.

Original comment by oshea.p...@gmail.com on 2 Dec 2010 at 9:10

GoogleCodeExporter commented 9 years ago
Yes, i'll move this to issue #96 which will resolve this issue.

Original comment by matthias...@gmail.com on 3 Dec 2010 at 12:07