search

aliemteam / aliemcards

ALiEM Cards - markdown and website
https://www.aliemcards.com
MIT License
4 stars 8 forks source link

add CI warnings for cards that have images without alt text #171

Closed dsifford closed 7 years ago

dsifford commented 7 years ago

CC: @jvoros

Once we fix the large number of warnings, I think we should convert the warnings to trigger a build failure. Alt text is super important for SEO and a11y.

codecov-io commented 7 years ago

Codecov Report

Merging #171 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   73.43%   73.43%           
=======================================
  Files          16       16           
  Lines         384      384           
  Branches      107      107           
=======================================
  Hits          282      282           
  Misses        102      102

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc0040d...8ad20f7. Read the comment docs.

dsifford commented 7 years ago

Example of warnings here: https://travis-ci.org/aliemteam/aliemcards/builds/229514686#L549

jvoros commented 7 years ago

This is fantastic.