Closed dsifford closed 7 years ago
Merging #198 into master will increase coverage by
1.11%
. The diff coverage is59.18%
.
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 54.14% 55.26% +1.11%
==========================================
Files 17 17
Lines 229 228 -1
Branches 56 53 -3
==========================================
+ Hits 124 126 +2
+ Misses 105 102 -3
Impacted Files | Coverage Δ | |
---|---|---|
app/categories/Category.tsx | 91.66% <0%> (ø) |
:arrow_up: |
app/App.tsx | 0% <0%> (ø) |
:arrow_up: |
app/components/Announcements.tsx | 0% <0%> (ø) |
:arrow_up: |
app/pages/Contact.tsx | 0% <0%> (ø) |
:arrow_up: |
app/pages/About.tsx | 100% <100%> (ø) |
:arrow_up: |
app/categories/Categories.tsx | 100% <100%> (ø) |
:arrow_up: |
app/components/Header.tsx | 100% <100%> (ø) |
:arrow_up: |
app/components/Search.tsx | 100% <100%> (ø) |
:arrow_up: |
app/components/Spinner.tsx | 100% <100%> (ø) |
:arrow_up: |
app/components/SearchResults.tsx | 91.66% <100%> (+0.75%) |
:arrow_up: |
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1cb8fd8...91b98a3. Read the comment docs.
@jvoros Can we merge this one first before your spinner fix?
Definitely. Totally missed this PR.
Prettier will be great.
On Fri, Jul 7, 2017 at 11:25 Derek Sifford notifications@github.com wrote:
@jvoros https://github.com/jvoros Can we merge this one first before your spinner fix?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aliemteam/aliemcards/pull/198#issuecomment-313743437, or mute the thread https://github.com/notifications/unsubscribe-auth/ACVxJr8do-cU9tofGT4PR0DgVRMx4nA0ks5sLmn2gaJpZM4N9SmZ .
cc: @jvoros
~Work in progress still -- don't merge just yet~
Edit: Should be good to go now.