aliemteam / aliemcards

ALiEM Cards - markdown and website
https://www.aliemcards.com
MIT License
4 stars 8 forks source link

Adds AddThis social sharing and email buttons #279

Open jvoros opened 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #279 into master will decrease coverage by 0.62%. The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   61.77%   61.15%   -0.63%     
==========================================
  Files          16       17       +1     
  Lines         259      278      +19     
  Branches       54       54              
==========================================
+ Hits          160      170      +10     
- Misses         99      108       +9
Impacted Files Coverage Δ
app/App.tsx 0% <0%> (ø) :arrow_up:
app/cards/Card.tsx 95% <100%> (+0.26%) :arrow_up:
app/components/AddThis.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 873cfd0...8faa919. Read the comment docs.

jvoros commented 6 years ago

It doesn't look like much in the end. But it took a lot of work to get there. Adding to the window event listener instead of react lifecycle hooks was the big fix.

dsifford commented 6 years ago

@jvoros I just tried actually running this now for the first time and it doesn't work for me.... Does it work for you?

dsifford commented 6 years ago

@jvoros Status on this?

dsifford commented 5 years ago

Can we close this?