Improve MQTT - Githubissues

alienatedsec / yi-hack-v5

Even newer Custom Firmware for Xiaomi Cameras based on Hi3518ev200 Chipset. It includes free RTSP, ONVIF and other improvements based on the work by roleoroleo

GNU General Public License v3.0

739 stars 87 forks source link

Improve MQTT #349

Closed Minims closed 4 months ago

Minims commented 4 months ago

Improve device data in MQTT integration
Does not retain camera config by default.

roleoroleo commented 4 months ago

I can't test it now, because my yi_home is down. But a couple of questions:

Is get_system_config() necessary? It seems she's never called
Line 91: variable HTTPD_PORT is empty (maybe it requires get_system_config()?).
Line 92: echo $DEVICE_DETAILS. Is it a typo?

If I can restore the cam tonight I will test it.

roleoroleo commented 4 months ago

We should shed some light on the mqtt world. There is a big overlap between mqttv4+mqtt-config and mqtt_adv_homeassistant.sh.

Minims commented 4 months ago

Is get_system_config() necessary? It seems she's never called

Line 91: variable HTTPD_PORT is empty (maybe it requires get_system_config()?).

Line 92: echo $DEVICE_DETAILS. Is it a typo?

I have fixed those 3 things :-).