alienbrett / PyAlly

Ally Invest API Module for Python3
https://alienbrett.github.io/PyAlly/
MIT License
57 stars 28 forks source link

Validations and News query params #57

Closed mm0 closed 3 years ago

mm0 commented 3 years ago

Hi @alienbrett, I noticed you added some new features to the project, which is great. I had previously worked on some similar features for News and Options search.

In this PR I am including startdate and enddate fields for News/Search, i'm not sure if this is backwards compatible due to the ordering of the method args, I can modify the ordering if desired.

This also includes an validation class for Options/Search called optionSearchQuery that allows you to provide only valid/supported queries for Options. I believe this is backwards compatible as I have set it up where you can either provide either a list of str or optionSearchQuery as the query argument in Option.search. Please review and feel free to modify any of the code and documentation.

Thank you.