aliencube / microsoft-teams-actions

This is a GitHub Actions that sends a message to a given channel in Microsoft Teams
MIT License
79 stars 23 forks source link

UriAction isn't working #1

Closed davidwengier closed 4 years ago

davidwengier commented 4 years ago

I think because you're just deserializing the JSON as BaseAction, which has no extra properties, the targets I'm specifying for me UriAction are being stripped.

See my input JSON:

[ { "@type": "OpenUri", "name": "View in GitHub", "targets": [ { "os": "default", "uri": "https://github.com/dotnet/project-system/pull/5812" } ] } ]

And the resulting data sent to the webhook:

"potentialAction": [
    {
      "@type": "OpenUri",
      "name": "View in GitHub"
    }
  ]

Full logs of the run are here: https://github.com/dotnet/project-system/pull/5812/checks?check_run_id=399958891

Is there a way to get links into the message otherwise?

justinyoo commented 4 years ago

@davidwengier Thanks for raising the issue! I'll have a look. The deserialising logic should be smarter than the current.

davidwengier commented 4 years ago

I'll try to find some time to have a look too. I got links working fine via markdown in the end though :)