alienfast / vite-plugin-i18next-loader

Vite plugin to client bundle i18next locales composited from one to many json/yaml files from one to many libraries. Zero config HMR support included.
Other
42 stars 3 forks source link

Update dependencies, remove non-working CJS artifact #10

Closed rosskevin closed 1 year ago

rosskevin commented 1 year ago

See discussion in #8.

📦 Published PR as canary version: 2.0.3--canary.10.59a9ede.0
:sparkles: Test out this PR locally via: ```bash npm install vite-plugin-i18next-loader@2.0.3--canary.10.59a9ede.0 # or yarn add vite-plugin-i18next-loader@2.0.3--canary.10.59a9ede.0 ```
rosskevin commented 1 year ago

I need a few people, preferably both in ESM and CJS setups to try out the canary before I release this. The canary release version is in the top comment.

rosskevin commented 1 year ago

Ok, yes, I worried this would happen, lodash replacing lodash-es fails in an ESM only environment. I'll discuss this in the issue.

rosskevin commented 1 year ago

Woohoo! ESM confirm works for 2.0.3--canary.10.047c5a3.0. I need a CJS tester to confirm.

rosskevin commented 1 year ago

While this PR is good to go for ESM, we confirmed the use of runtime dependency dot-prop is a non-starter as it is ESM-only. We need alternatives that ship both cjs and esm distributables in a package of the same name with proper exports specified in the package.json.

rosskevin commented 1 year ago

We are removing the CJS artifact - this is discussed in #8 and a workaround for CJS users is here https://github.com/alienfast/vite-plugin-i18next-loader/issues/8#issuecomment-1528843249

rosskevin commented 1 year ago

:rocket: PR was released in v2.0.3 :rocket: