search

alienfast / vite-plugin-i18next-loader

Vite plugin to client bundle i18next locales composited from one to many json/yaml files from one to many libraries. Zero config HMR support included.
Other
42 stars 4 forks source link

Fix ESM bug, remove private dep #9

Closed agustif closed 1 year ago

agustif commented 1 year ago

Fixes #8

jamespearson commented 1 year ago

Please approve and release this.

gamegee commented 1 year ago

@rosskevin good for you to merge ?

agustif commented 1 year ago

@gamegee @jamespearson until it gets merged feel free to use this one https://www.npmjs.com/package/vite-plugin-i18next-loader-cjs

rosskevin commented 1 year ago

I'm sorry, I didn't get a notification on this! Only the comment. Reviewing now...

rosskevin commented 1 year ago

I'm surprised that auto didn't provide a usable release from this PR...I'll have to look at the settings.

agustif commented 1 year ago

I'm surprised that auto didn't provide a usable release from this PR...I'll have to look at the settings.

I didn't knew about auto when I opened the PR, I was mainly trying to fix it to use myself. You suggested to change back from lodash-es to lodash. That's what was fixing the issue! Any ideas how to solve properly?

rosskevin commented 1 year ago

@agustif I looked into why a canary release wasn't added to this PR by auto, and it's because you included skip ci in your last message (HEAD) before you PR'd. If your latest commit was pushed - then you would have a canary to try.

I'm going to take a look at opening our eslint config so we can keep it. I'd prefer it. Give me a couple of hours to take a look at that - I should get this resolved today.

rosskevin commented 1 year ago

Github package is public now for @alienfast/eslint-config, I'll take a shot at this myself in another PR and we can try it out.

rosskevin commented 1 year ago

Closing in favor of my PR to solve this #10. I need the canary to be tested before I'll release it. Please take a look and test it out and comment there.