search

alienlebarge / inuit-layout-flexbox

Flexbox grid system for inuitcss
1 stars 3 forks source link

Feature/variable fix #23

Closed ghost closed 9 years ago

ghost commented 9 years ago

!global flag throws error in node-sass 2.1.1

alienlebarge commented 9 years ago

Next time, please do one PR per feature. It will be easier to deal with :wink:

ghost commented 9 years ago

Thanks for taking the changes in account. With the flexbox module the original layout styling is altered. Therefor I introduced the classname so you have the possibility to overrule it (default behaviour isn't changed, it still targets the normal .layout classname, but in my case I changed it to .layout--flex (within the inuit config file in our project) because I don't want this behaviour as a default but as an addition.

ghost commented 9 years ago

I actually didn't rename the class, but made the possibility to rename it.. :smile: The change on line 79 is necessary if you want to rename the class. Good point about the PR per feature!

ghost commented 9 years ago

You're right about the !global though (they can stay), but I had to add the $inuit-generate-responsive-item-alias: null !default; else I got this error when compiling:

[09:52:42] gulp-notify: [Gulp notification] unbound variable $inuit-generate-responsive-item-alias inuit-flexbox/_objects.flexbox.scss

alienlebarge commented 9 years ago

Since the user as deleted his account (!), I close this PR.