search

alienscience / imapsrv

An IMAP server written in Go
BSD 3-Clause "New" or "Revised" License
48 stars 9 forks source link

Multiple Listener #12

Closed g-dormoy closed 9 years ago

g-dormoy commented 9 years ago

Hi guys,

When xarg refactored the server configuration he chose to add a slice of listener to the configuration which is a good idea. For now this slice is useless because in the Server.Start() function there is an infinite loop inside the loop iterating the listeners slice so only one listener is accepting connection.

I think we should put that infinite loop into a goroutine so that we accept connection on all listeners at the same time.

What do you think?

twitchyliquid64 commented 9 years ago

Welp, I should have notices that before I approved the PR lol.

Yeah, feel free to fix. On Nov 5, 2014 11:44 PM, "Guillaume" notifications@github.com wrote:

Hi guys,

When xarg refactored the server configuration he chose to add a slice of listener to the configuration which is a good idea. For now this slice is useless because in the Server.Start() function there is an infinite loop inside the loop iterating the listeners slice so only one listener is accepting connection.

I think we should put that infinite loop into a goroutine so that we accept connection on all listeners at the same time.

What do you think?

— Reply to this email directly or view it on GitHub https://github.com/alienscience/imapsrv/issues/12.

g-dormoy commented 9 years ago

Hi guys I'm getting off this ticket, my laptop broke last month and my productivity got ruined with it (I can't get to code on my desktop...)

I'll be back when I can but if anyone wants to make change on this feel free