search

aliev / aioauth

Asynchronous OAuth 2.0 provider for Python 3
https://aliev.me/aioauth
MIT License
214 stars 19 forks source link

Use dataclasses instead of namedtuples #58

Closed grmnz closed 2 years ago

grmnz commented 2 years ago

I prepared a pr based on the comments from discussion https://github.com/aliev/aioauth/discussions/57

codecov-commenter commented 2 years ago

Codecov Report

Merging #58 (4d4db19) into master (6c0aa10) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          595       615   +20     
  Branches       117       117           
=========================================
+ Hits           595       615   +20
Impacted Files Coverage Δ
aioauth/config.py 100.00% <100.00%> (ø)
aioauth/models.py 100.00% <100.00%> (ø)
aioauth/requests.py 100.00% <100.00%> (ø)
aioauth/responses.py 100.00% <100.00%> (ø)
aioauth/server.py 100.00% <100.00%> (ø)
aioauth/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c0aa10...4d4db19. Read the comment docs.

aliev commented 2 years ago

@grmnz sorry for the delay! checking now :)

aliev commented 2 years ago

according to this check https://github.com/aliev/aioauth/runs/5276888168?check_suite_focus=true it seems Python 3.6 doesn't support dataclasses. but on the other hand Python 3.6 is no longer supported officially: https://endoflife.date/python

I think we should remove python 3.6 support and add python 3.10 support.

aliev commented 2 years ago

I removed Python 3.6 support within this PR: https://github.com/aliev/aioauth/pull/59 and updated this branch.