search

alifleisch / TravelPlan

An application where users can plan their trips, add places they want to visit and create routes.
https://alifleisch.github.io/TravelPlan/
0 stars 0 forks source link

best practice guidelines #1

Open WuglyakBolgoink opened 3 months ago

WuglyakBolgoink commented 3 months ago

https://github.com/alifleisch/TravelPlan/blob/17d31be8a0bfce828d2c1db338acd98caa4cde4b/src/app/services/trip.service.ts#L10

  1. please eliminate DI from contructor and replace this with injections
  2. use "#" for all private variables. At the end it should be this.#http

is:

constructor(private http: HttpClient) { }

should:

#http = inject(HttpClient);

constructor() { } // todo: delete this line
dmitry-urenev commented 3 months ago

@WuglyakBolgoink could you provide a link to the best practice guidelines you are following?