aliftype / qahiri

Qahiri (قاهري) is a manuscript Kufic typeface
https://aliftype.com/qahiri/
SIL Open Font License 1.1
54 stars 8 forks source link

Use GNU-Make 4.3+ compatible space variable 'hack' #1

Closed alerque closed 4 years ago

alerque commented 4 years ago

The hack that has been around for years (and I have used myself many places, possibly even introducing you to it :fearful:) to create a variable with a single space relied on GNU-Make's handling of appending variables always adding a space first. In version 4.3 they introduced a breaking change which effectively trims after append operations.

  • WARNING: Backward-incompatibility! Previously appending using '+=' to an empty variable would result in a value starting with a space. Now the initial space is only added if the variable already contains some value. Similarly, appending an empty string does not add a trailing space. (source)

This PR uses a current and backwards compatible way of avoiding the trim operation.

khaledhosny commented 4 years ago

Thanks!