search

aliftype / xits

XITS - OpenType implementation of STIX fonts with math support
SIL Open Font License 1.1
351 stars 35 forks source link

Circumflex and diaresis misplaced on lowercase i #78

Closed dbenjaminmiller closed 5 years ago

dbenjaminmiller commented 5 years ago

not on other vowels, nor on capital I, it seems, nor with other accents: but see this:

Inherited from STIX but this is an obvious bug (these accents are placed too far right.) Affects regular, italic, italic and bold italic.

Screenshot_2019-08-17_11-51-26

sample lines in XITS and Nimbus Roman for comparison; the vowels below are all XITS

dbenjaminmiller commented 5 years ago

Actually, it seems that it's more that the i itself is too far left:

Screenshot_2019-08-17_11-57-04

khaledhosny commented 5 years ago

Can you provide the actual string, what application is this?

dbenjaminmiller commented 5 years ago

Not application-specific. This is an issue with the design of î and ï. Open up the font in FontForge and you will see the defect in these two characters.

khaledhosny commented 5 years ago

I see, I thought it is an issue with mark positioning (which we don’t handle), but I now see that the i part is displaced in these glyphs.

dbenjaminmiller commented 5 years ago

Yep. I would say it is a pretty big QC issue in French, and should probably be fixed in the release version quickly and not just the master … I'm just surprised it wasn't caught earlier.

dbenjaminmiller commented 5 years ago

I just checked, and Type1 STIX is affected as well. So the issue is ancient.

khaledhosny commented 5 years ago

I’m fixing them. Though I don’t see the urgency given how long they have been broken.

dbenjaminmiller commented 5 years ago

Fair if you don't, I suppose. I am a bit surprised that STI didn't catch them though

dbenjaminmiller commented 5 years ago

Issue still present in the italic and bold italic. Slightly more subtle but same problem.

khaledhosny commented 5 years ago

I did check these fonts and the accented i glyphs had the i at the same place as the dotless i (unless the dotless i is misplaced as well).

dbenjaminmiller commented 5 years ago

Just took a look. you're right that the base glyph is not misplaced. In these fonts, it seems that it is the accent, rather, which is off.

khaledhosny commented 5 years ago

That is probably subjects. I checked Times (that ships with macOS) and it is very close to XITS. Times New Roman is lightly different, but its accents are smaller too.

dbenjaminmiller commented 5 years ago

image Background is Mac Times.

khaledhosny commented 5 years ago

Which why I said very close, not identical. I don’t think it has to be identically placed and it does not look misplaced to me, but feel free to change if you strongly feel so.

dbenjaminmiller commented 5 years ago

Upon further inspection, the italic fonts seem fine in print.