search

aligator / GoSlice

This is an experimental slicer for 3d printing written in Go also usable as modular slicing lib.
Apache License 2.0
110 stars 17 forks source link

Fixes for #54 #55

Closed ivano85 closed 2 years ago

ivano85 commented 2 years ago

Fixes for #54

Continuing the topic of zHop, you're right and I restored the retraction speed as it had to be.

For the moment I applied the changes initially suggested by you (restoring AddCommand), because I'm not sure yet about how the old method and the new AddMoveSpeed should behave: shoud the new method just use the AddCommand with just a bit more logic to build the actual command and change the current coordinates?

ivano85 commented 2 years ago

I'm sorry, wait before merging... I will have to double check the change, because I'm thinking we really need an AddMoveSpeed function in place of just the AddCommand, to be able to restore the move speed changed by the retraction speed. I will review it later or tomorrow.

ivano85 commented 2 years ago

Hi, I pushed the AddMoveSpeed function and changes to use it.

I actually moved most code from the AddMove to AddMoveSpeed, in this way all movements should reflect the actual moves on the printer (all positions known and well managed, all speeds always known and well managed).

In practice, now AddCommand must never be called to issue "G0" or "G1" commands.

Let me know ;-)

aligator commented 2 years ago

Damnit, I did it again^^ (I somehow connected my local master with your branch and vs code just pulled and pushed it)

However I think its ok now.

I only adapted the tests because your code change results in repeating positions to be omitted (which is actually better) Also I made sure that the first moves in each direction never gets omitted, e.g. to support the case where the first move is to 0.

Before I release it in A new version, I will test it with a real printer. If everything works as expected I will release that as v0.5.0 soon :-)

Thank you for your contribution and ideas

ivano85 commented 2 years ago

Oh thank you for your work... It's a very good project, at least for what I need. I hope to be able to provide more improvements in the future.

Actually I have some more ideas for other improvements, but I will need to implement more things before actually thinking to them... I'll let you know.

aligator commented 2 years ago

Nice, I am myself currently not working on this project much as I have other things going on, but still I am happy for any contribution :-) It is very nice to know that someone actually uses it :+1:

aligator commented 2 years ago

Just did a test-benchy-print, the Z-Hop works fine :-) Thanks!