Closed leogold closed 10 years ago
Hi,
My fix may not be very clean since I do not have programing background. Just did my fix. :) If you still want I can respond the pull request.
I figure out the _value option, this is I took out the support question.
I am including nodes in the XML. One of the was the manufacturer.
By the way, you did an amazing job. I upload the XML to google today, lets see if we get the product online tomorrow.
On 20/05/2014, at 21:02, aligentjim notifications@github.com wrote:
Is it an easy way to include the brand/manufacturer info? I have included the tag on the config.xml, but it inserts the manufacturer id, not the text. I tried to use , but no luck.
On the image link, It was missing the /catalog/product on the path for me. I included on the config.xml. Worked like a charm.
Thank you, Leo
Hi Leo,
If you wanted to raise a pull request for the image URL fix, I'd happily merge it in!
When Magento builds the flat table for an attribute with a data source (i.e. any select attributes such as manufacturer), it actually adds two columns to the table which contains the option id that's stored in the attribute, and _value which contains the textual value that you see in the select box. In the case of the manufacturer attribute, those columns would be called manufacturer and manufacturer_value, if you use manufacturer_value in your config.xml instead of manufacturer, you should get what you're looking for. Failing that, there's also the option to use nodes in the XML and perform the mapping yourself.
— Reply to this email directly or view it on GitHub.
Hi,
We love feedback and welcome contributions to our open source code. If you're not confident that your fix is the right approach, I'd be happy to code review and work with you to get it in shape. Or, I'm happy to make the change myself, it's up to you.
By the way, you did an amazing job.
Thanks! We found everyone had slightly different requirements for their feeds (and Google's own requirements change depending on country and industry), so we set out to build a reusable core, that we could extend to suit specific requirements. It took a couple of iterations to come up with what you see here, but we're really happy with it. I'm glad you were able to make it fit your needs as well.
Jim.
Hi Jim,
I have only changed the formatter e the config.xml files.
I am still waiting to see if Google approves my products.
You are right, I am in Brazil and it has some differences...
I will keep including more fields, I am planning to include color variation. Not sure yet
Thank you, and If i can contribute in any way, you can count on me.
Leo
On 20/05/2014, at 22:37, aligentjim notifications@github.com wrote:
Hi,
We love feedback and welcome contributions to our open source code. If you're not confident that your fix is the right approach, I'd be happy to code review and work with you to get it in shape. Or, I'm happy to make the change myself, it's up to you.
By the way, you did an amazing job.
Thanks! We found everyone had slightly different requirements for their feeds (and Google's own requirements change depending on country and industry), so we set out to build a reusable core, that we could extend to suit specific requirements. It took a couple of iterations to come up with what you see here, but we're really happy with it. I'm glad you were able to make it fit your needs as well.
Jim.
— Reply to this email directly or view it on GitHub.
Hi Leo,
If you wanted to raise a pull request for the image URL fix, I'd happily merge it in!
When Magento builds the flat table for an attribute with a data source (i.e. any select attributes such as manufacturer), it actually adds two columns to the table which contains the option id that's stored in the attribute, and _value which contains the textual value that you see in the select box. In the case of the manufacturer attribute, those columns would be called manufacturer and manufacturer_value, if you use manufacturer_value in your config.xml instead of manufacturer, you should get what you're looking for. Failing that, there's also the option to use nodes in the XML and perform the mapping yourself.