First Round Bug Fixes

[aligentjim]

Fixes the following issues from Oro's code review:

• Remove References to $_POST global - Just need to inject the request stack and pull from the request object instead fairly straightforward, worst case scenario we need to use the payment transaction object to pass it around.
• minified braintree js files - Best case: Require.js can reference externally hosted script direct from braintree. Worst case, we either need to download and commit the script ourselves OR find a way to inject (and reference) into the DOM
• Move Helper to DI container - Simple change, just shouldn't be new'ing up an object like that
• Refactor Helper operations - Braintree Helper hardcodes operations and there classes to then new them up dynamically. Should use an abstract service in the DI then create a service for each opertion and tag them, then use a compiler pass to collect all the operations and add to the helper. (Again not a huge issue but a nicer way of doing it)
• Fix isNullDataToSend and set functions in AbstractBraintreePurchase - Data formatting methods that check if something is null and just return empty strings, They're workable but not ideal...
• 3.0 Update changes - I noticed in the Oro 3.0 patch notes that the Paypal express module is currently unsupported on 3.0, this may be due to changes in the checkout and I would need some more time to investigate
• Payment listener needs to check payment method - Simple if statement, and testing
• Move Customer credit card tokens to their own entity - If there is an event to hook into this should be relatively simple, otherwise we may need to add some javascript to call a customer controller to store the tokens. Entity already exists but it does not have relationships, it's just storing the customer id and transaction Id this should be updated to be relationships with the customer user and transaction entities
• Remove strcmp - These are littered throughout the code, may take some time to remove all of them. Not sure on neccessity of this as I have actually never used strcmp before??
• Remove Channel Constant or Move to actual constant - Looks like this will be safe to remove from the braintree docs, but would just require testing
• Refactor New Credit Card Purchase to be more DRY - Repeated data blocks, with simple differences between new and old credit cards. Should be simple to create a helper to parse the data to expected formats
• Remove magic method calls - On an unused variable anyway, so should just be safe to remove entirely
• Undefined namespace - Just a typo..

[aligentjim]

Getting the tagging in the DI container working was a bit of a challenge, but I like the way it turned out. Kind of forced me into creating a factory class, but the end result is pretty neat. And we don't have to spin up a bunch of dependencies "just in case".