Feature/version 2

[aligent-lturner]

Feature Changes

• PHP version requirement change (backwards incompatible) - Add PHP 8 support, remove support for < 7.3

• Remove Suburb, Gallery, Allow Store Delivery fields

  • Suburb field had potential to be confusing with city, and is not required by most users.
  • Allow store delivery added no extra functionality other than the flag itself. This should be handled specifically within a project when needed.
  • "Gallery" was not clear as to purpose. It was purely PageBuilder content.
• Description field has been enabled for PageBuilder
• Removed unused postcode input for stockists GraphQL query
• Actual validation errors can now be seen when saving a stockist.
• Add default sorting (by distance) to stockist queries
• Added a readme

Technical Changes

• Ensure all functions specify parameter and return types (unless conflicting with parent class)
• Ensure PHPDoc is present and correct
• Do not use classes from Magento Inventory modules
• Do not allow function chaining (return void from set functions)
• Use a virtual type to handle hydrator injection instead of a concrete class
• Use foreach instead of array_map when returning stockist data
• Cast to booleans instead of comparing to specific strings
• Add JS validation of trading hours (must be a valid JSON string)
• Add schema whitelist

[brettlaishley]

Suburb field had potential to be confusing with city, and is not required by most users. Allow store delivery added no extra functionality other than the flag itself. This should be handled specifically within a project when needed. "Gallery" was not clear as to purpose. It was purely PageBuilder content.

As an FYI, Suburb and Allow Store Delivery could definitely have been project specific. Allow Store Delivery seemed like it might have a slight benefit to include for other users of the module.

Gallery was a 2nd pagebuilder attribute dedicated to more of a photographic display of the store, as opposed to a stand alone description field. It gave the flexibility to provide two pagebuilder areas to create different content for the GQL response. I can see your point it could be project specific but it seemed like a decent inclusion to expand this module for other uses.

[aligent-lturner]

@brettlaishley I'm not 100% against a "gallery" field, but I think it needs to be thought out better/more clearly. Having actual image urls (e.g. with an image uploader component) would allow for this with more flexibility that a pagebuilder component.