aligent / magento-stockists-module

GNU General Public License v3.0
1 stars 1 forks source link

fix: Let handleTradingHours accept default store_id of string 0 (falsey) #27

Closed brettlaishley closed 2 years ago

brettlaishley commented 2 years ago

As discussed in the PR to develop-1.x, if no store_ids are set or from a previous implementation, or the default store_id is set, the logic in handleTradingHours does not set an array and getStoreIds throws an error.

The other changes from my PR to develop-1.x are up for debate as to whether you wish to include them. I've updated db_schema.xml in client project to set url_key to nullable, 2.X also allows for the null return type in the getter.