search

aligol20 / AdaKerja-ReactNative-Task

Simple Project for login to a GitHub account and see the list of every repository's commits
0 stars 0 forks source link

review #1

Open ashwintiwari88 opened 4 years ago

ashwintiwari88 commented 4 years ago

folder structure is not good enough (negative) inline css (negative) using type script white_check_mark (positive) functions and actions are in components (negative) but used a nice design and animation (positive)

unfortunately we will pass at this current stage @aligol20

aligol20 commented 4 years ago

Did you pay attention to the things that you wanted from us? You even did not understand the pagination in both sides of searching and commits list... You told that pagination is a big bonus...

On Fri, Jun 5, 2020, 05:04 Ashwin Tiwari notifications@github.com wrote:

folder structure is not good enough red_circle inline css red_circle using type script white_check_mark functions and actions are in components red_circle but used a nice design and animation

unfortunately we will pass at this current stage ali

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aligol20/AdaKerja-ReactNative-Task/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACAZRQMCODLYIIZXXMASAV3RVA4QZANCNFSM4NTDEQDQ .