search

aligrudi / neatroff_make

Neatroff top-level makefile
50 stars 15 forks source link

Fixmm approved signature #11

Open mcctuxic opened 3 years ago

mcctuxic commented 3 years ago

Fix for the mm macro package. Error: The date field of the signature line does not print (AV-Macro). Fix : Missing apostroph added, date field now prints ok. Bug and correction was found by Andreas Eder.

aligrudi commented 3 years ago

mcctuxic notifications@github.com wrote:

Fix for the mm macro package. Error: The date field of the signature line does not print (AV-Macro). Fix : Missing apostroph added, date field now prints ok. Bug and correction was found by Andreas Eder.

This is applied.

Thanks, Ali

mcctuxic commented 3 years ago

Hi Ali,

Thanks a lot! :)

One techical questin: Github shows me, that the according pull-request is "open". For me, this sounds like "unapplied" - but is applied. It think, ... I am ....confused? ;)

What does "open" means then?

Cheers! Meino

On 03/01 01:37, Ali Gholami Rudi wrote:

mcctuxic notifications@github.com wrote:

Fix for the mm macro package. Error: The date field of the signature line does not print (AV-Macro). Fix : Missing apostroph added, date field now prints ok. Bug and correction was found by Andreas Eder.

This is applied.

Thanks, Ali

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/aligrudi/neatroff_make/pull/11#issuecomment-788314504

aligrudi commented 3 years ago

Hi Meino,

mcctuxic notifications@github.com wrote:

Thanks a lot! :)

One techical questin: Github shows me, that the according pull-request is "open". For me, this sounds like "unapplied" - but is applied. It think, ... I am ....confused? ;)

What does "open" means then?

You can close it. There is also someway of closing it automatically by including some keyword in commit messages, the details of which I cannot recall...

Thanks, Ali