search

aligrudi / neatroff_make

Neatroff top-level makefile
50 stars 15 forks source link

replace git to https #22

Open Konstantin8105 opened 2 years ago

Konstantin8105 commented 2 years ago

minor changes

aligrudi commented 2 years ago

Konstantin @.***> wrote:

minor changes You can view, comment on, or merge this pull request online at:

https://github.com/aligrudi/neatroff_make/pull/22

-- Commit Summary --

-- File Changes --

M Makefile (12)

-- Patch Links --

https://github.com/aligrudi/neatroff_make/pull/22.patch https://github.com/aligrudi/neatroff_make/pull/22.diff

Thanks for the patch.

I personally sometimes build git without HTTPS support, mainly because of its curl dependency. Maybe it is a better idea to use git protocol by default. What is your opinion?

Ali
Konstantin8105 commented 2 years ago

Hello, As I see - 2 acceptable cases 

https://github.com/aligrudi/neatroff_make.git
git@github.com:aligrudi/neatroff_make.git

git

In your Makefile:

git://github.com/aligrudi/neatroff.git

I do not check case with git, but I suppose git@github.com:aligrudi/<your repository name> will work.

aligrudi commented 2 years ago

Hello,

Konstantin @.***> wrote:

As I see - 2 acceptable cases

I have merged the git to https patch, as Github no longer supports the former.

Thanks, Ali

Konstantin8105 commented 2 years ago

Feel free for closing that PR