search

alikaragoz / MCSwipeTableViewCell

:point_up_2: Convenient UITableViewCell subclass that implements a swippable content to trigger actions (similar to the Mailbox app).
MIT License
2.96k stars 412 forks source link

sectionIndexTitlesForTableView #20

Closed mychrisdangelo closed 11 years ago

mychrisdangelo commented 11 years ago

When I was using sectionIndex (alphabetical on the right side) the color underlying the cell is exposed. It's possible to get around this by adding another view (hack) to mask it but have I done something wrong or is this a known issue.

If I've been unclear please let me know and I will elaborate.

And thanks again for the great library.

alikaragoz commented 11 years ago

Hello @mychrisdangelo, can you please check if with the recent changes in the code you still have the issue you are talking about? If this is the case can you please send us a screenshot? Thanks :wink:

mychrisdangelo commented 11 years ago

Hey @alikaragoz, I will try to get my act together and investigate this problem myself instead of just complaining ;)

I still see the issue after copying the new .h and .m into our project. You can see two screenshots of the iPhone Simulator:

screenshot with a table index where the index on the right side exposes the tableview background color

indexgrab

and a screenshot without a tableview index where there isn't any problem.

withoutindex

Not sure where the problem lies but I thought I would bring it to your attention. My cells are generated from a xib. You can see in screenshot below the small white colored UIView I've added as a hack to cover up the Index area. With this hack it appears like everything is working as expected.

cellxib

As I said, I really appreciate how great MCSwipeTableViewCell looks and how easy it was to use so if I get some time and can figure out what's going on I'll be sure to send a pull request. If you haven't experienced the issue then I should definitely take a closer look at what our code could be doing to cause the issue.

mychrisdangelo commented 11 years ago

My apologies. I thought before I wrote about this issue I'd done enough testing but after reviewing the code again I believe this symptom is because of a mistake in our code.

Again, sorry for the trouble.

Best.

alikaragoz commented 11 years ago

No worries, thanks for your feedback :smile: