search

alikh31 / node-red-contrib-eq3-bluetooth

node-red binding to bluetooth eq3 radiator valves without Max! Cube
MIT License
10 stars 5 forks source link

Case sensitiveness of the Bluetooth Address #10

Open ouinouin opened 6 years ago

ouinouin commented 6 years ago

Hi, I had a lot of difficulties to connect to my Thermostatic valves, I had to learn a bit javascript to finally understand that if you enter in the nodered field an address like : 00:1A:22:0D:E9:B4 , this will lead the noble-device function discoverWithFilter (in utils.js from the noble-device JS libs) to never match with 00:1a:22:0d:e9:b4 as represented by noble. I suggest you to insert a function to force the letters to be lowerecased or to mention explicitely this limitation in the help. I think as a user of the noble library , this Case sensitiveness issue would be better solved in the noble library , what do you think ? do you have a bit of time to push this issue to noble devs ? Regards and thanks for giving us back control on thermostats :-)

alikh31 commented 6 years ago

Hey @ouinouin, thanks for reporting the issue, as you mentioned it should be quite easy for fix the issue both from out side and noble side. Unfortunately currently I am quite busy with another project of mine as soon as I find the time will release a new version that has this issue fixed meanwhile if you feel like fixing the issue yourself and opening a PR I can make sure the code is updated after the merge.

ouinouin commented 6 years ago

Hi, thanks for your answer, i submitted the input here : https://github.com/noble/noble-device/issues/29

janvda commented 5 years ago

Maybe it would be good to document this in the node documentation that this is case sensitive and that it should be specified in small capitals.