alikothari / htmlcompressor

Automatically exported from code.google.com/p/htmlcompressor
Apache License 2.0
0 stars 0 forks source link

preserve-line-breaks causes StackOverFlow when consumed 2000 empty lines. #101

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. yes "" | head -n2000 > manylines
2. java -jar Downloads\htmlcompressor-1.5.3.jar --preserve-line-breaks manylines
3. crashes by StackOverFlow exception

What is the expected output? What do you see instead?
expected output is compressed html
instead I see fatal error.

What version of the product are you using? On what operating system?
htmlcompressor 1.5.3

java version "1.8.0_31"
Java(TM) SE Runtime Environment (build 1.8.0_31-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.31-b07, mixed mode)

Windows 8.1 64bit

Please provide any additional information below.
I attached full stack trace by adding -XX:MaxJavaStackTraceDepth=1000000 option.

I think the last quantifier of lineBreakPattern in HtmlCompressor.java should 
use '++' instead of '+'.

Original issue reported on code.google.com by Hideki.Y...@gmail.com on 31 Jan 2015 at 12:11

Attachments:

GoogleCodeExporter commented 9 years ago
Hi, 

I'm also running into this error on 1.5.2. Setting --preserve-line-breaks to 
false doesn't fix it, and neither does manually stripping out newlines in the 
html before running it through the compressor.

Original comment by g.sas...@gmail.com on 7 Apr 2015 at 12:52