Closed alikureishy closed 5 years ago
alikureishy
commented
5 years ago The issue was that the enum package referenced in the params.py file exists out-of-box in python 3.6+. Python 2.7 doesn't have that library out-of-box, so it had to be added explicitly, via the 'enum34' library. I’ve changed the requirements file to install this.
Verichev
commented
5 years ago Hi, Ali, did you submitted the project again?
On 1 Aug 2019, at 1:12 AM, Ali Safdar Kureishy notifications@github.com wrote:
The issue was that the enum package referenced in the params.py file exists out-of-box in python 3.6+. Python 2.7 doesn't have that library out-of-box, so it had to be added explicitly, via the 'enum34' library. I’ve changed the requirements file to install this.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/safdark/Automata-Capstone/pull/28?email_source=notifications&email_token=ABZEKJOHPNFBIX7NS7UEDMTQCHBXTA5CNFSM4IH5QSGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3H5YNQ#issuecomment-516938806, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZEKJNQIIB7EMR5KAZH34LQCHBXTANCNFSM4IH5QSGA.
alikureishy
commented
5 years ago Hi Eugene, Sorry I'm traveling and haven't had access to the GPU machine that I was using for this project at home. Yes, I resubmitted the project. I had missed the instruction to submit it again, so I just did it in case it was holding up anyone's graduation. Did you get the graduation email? And have you filled out the survey? It seems that survey step is required in order to receive the certificate. Ali
On Sat, Aug 17, 2019 at 11:43 AM Eugene Verichev notifications@github.com wrote:
Hi, Ali, did you submitted the project again?
On 1 Aug 2019, at 1:12 AM, Ali Safdar Kureishy notifications@github.com wrote:
The issue was that the enum package referenced in the params.py file exists out-of-box in python 3.6+. Python 2.7 doesn't have that library out-of-box, so it had to be added explicitly, via the 'enum34' library. I’ve changed the requirements file to install this.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub < https://github.com/safdark/Automata-Capstone/pull/28?email_source=notifications&email_token=ABZEKJOHPNFBIX7NS7UEDMTQCHBXTA5CNFSM4IH5QSGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3H5YNQ#issuecomment-516938806>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABZEKJNQIIB7EMR5KAZH34LQCHBXTANCNFSM4IH5QSGA .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/safdark/Automata-Capstone/pull/28?email_source=notifications&email_token=AAJDKAY3IFSPJNBQSLSXQW3QFBBGBA5CNFSM4IH5QSGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QRHUY#issuecomment-522261459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJDKAYDRNCXEFTGDKTRBPDQFBBGBANCNFSM4IH5QSGA .
alikureishy
commented
5 years ago I will try out what you suggested as soon as I'm back home...
On Sat, Aug 17, 2019 at 12:51 PM Ali Safdar Kureishy < safdar.kureishy@gmail.com> wrote:
Hi Eugene, Sorry I'm traveling and haven't had access to the GPU machine that I was using for this project at home. Yes, I resubmitted the project. I had missed the instruction to submit it again, so I just did it in case it was holding up anyone's graduation. Did you get the graduation email? And have you filled out the survey? It seems that survey step is required in order to receive the certificate. Ali
On Sat, Aug 17, 2019 at 11:43 AM Eugene Verichev notifications@github.com wrote:
Hi, Ali, did you submitted the project again?
On 1 Aug 2019, at 1:12 AM, Ali Safdar Kureishy < notifications@github.com> wrote:
The issue was that the enum package referenced in the params.py file exists out-of-box in python 3.6+. Python 2.7 doesn't have that library out-of-box, so it had to be added explicitly, via the 'enum34' library. I’ve changed the requirements file to install this.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub < https://github.com/safdark/Automata-Capstone/pull/28?email_source=notifications&email_token=ABZEKJOHPNFBIX7NS7UEDMTQCHBXTA5CNFSM4IH5QSGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3H5YNQ#issuecomment-516938806>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABZEKJNQIIB7EMR5KAZH34LQCHBXTANCNFSM4IH5QSGA .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/safdark/Automata-Capstone/pull/28?email_source=notifications&email_token=AAJDKAY3IFSPJNBQSLSXQW3QFBBGBA5CNFSM4IH5QSGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QRHUY#issuecomment-522261459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJDKAYDRNCXEFTGDKTRBPDQFBBGBANCNFSM4IH5QSGA .
alikureishy
commented
5 years ago This was my 5th Nanodegree, so I've been needing a break for quite a long time to recharge.
On Sat, Aug 17, 2019 at 12:54 PM Ali Safdar Kureishy < safdar.kureishy@gmail.com> wrote:
I will try out what you suggested as soon as I'm back home...
On Sat, Aug 17, 2019 at 12:51 PM Ali Safdar Kureishy < safdar.kureishy@gmail.com> wrote:
Hi Eugene, Sorry I'm traveling and haven't had access to the GPU machine that I was using for this project at home. Yes, I resubmitted the project. I had missed the instruction to submit it again, so I just did it in case it was holding up anyone's graduation. Did you get the graduation email? And have you filled out the survey? It seems that survey step is required in order to receive the certificate. Ali
On Sat, Aug 17, 2019 at 11:43 AM Eugene Verichev < notifications@github.com> wrote:
Hi, Ali, did you submitted the project again?
On 1 Aug 2019, at 1:12 AM, Ali Safdar Kureishy < notifications@github.com> wrote:
The issue was that the enum package referenced in the params.py file exists out-of-box in python 3.6+. Python 2.7 doesn't have that library out-of-box, so it had to be added explicitly, via the 'enum34' library. I’ve changed the requirements file to install this.
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub < https://github.com/safdark/Automata-Capstone/pull/28?email_source=notifications&email_token=ABZEKJOHPNFBIX7NS7UEDMTQCHBXTA5CNFSM4IH5QSGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3H5YNQ#issuecomment-516938806>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABZEKJNQIIB7EMR5KAZH34LQCHBXTANCNFSM4IH5QSGA .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/safdark/Automata-Capstone/pull/28?email_source=notifications&email_token=AAJDKAY3IFSPJNBQSLSXQW3QFBBGBA5CNFSM4IH5QSGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4QRHUY#issuecomment-522261459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJDKAYDRNCXEFTGDKTRBPDQFBBGBANCNFSM4IH5QSGA .
I haven't yet been able to test this out, but I will when I have access to the ROS environment again. Meanwhile, you can take a look at the fix.