hardingnj
commented
10 years ago Added test and added tped code
Closed hardingnj closed 10 years ago
hardingnj
commented
10 years ago Added test and added tped code
alimanfoo
commented
10 years ago Hi Nick, do you want to resubmit this as a new PR? Was a good idea.
On Thursday, September 18, 2014, hardingnj notifications@github.com wrote:
Closed #59 https://github.com/alimanfoo/anhima/pull/59.
Reply to this email directly or view it on GitHub https://github.com/alimanfoo/anhima/pull/59#event-167282977.
Alistair Miles Head of Epidemiological Informatics Centre for Genomics and Global Health http://cggh.org The Wellcome Trust Centre for Human Genetics Roosevelt Drive Oxford OX3 7BN United Kingdom Web: http://purl.org/net/aliman Email: alimanfoo@gmail.com Tel: +44 (0)1865 287721
hardingnj
commented
10 years ago Will do, shall I pr to your master?
On 23/09/14 18:03, Alistair Miles wrote:
Hi Nick, do you want to resubmit this as a new PR? Was a good idea.
On Thursday, September 18, 2014, hardingnj notifications@github.com wrote:
Closed #59 https://github.com/alimanfoo/anhima/pull/59.
Reply to this email directly or view it on GitHub https://github.com/alimanfoo/anhima/pull/59#event-167282977.
Alistair Miles Head of Epidemiological Informatics Centre for Genomics and Global Health http://cggh.org The Wellcome Trust Centre for Human Genetics Roosevelt Drive Oxford OX3 7BN United Kingdom Web: http://purl.org/net/aliman Email: alimanfoo@gmail.com Tel: +44 (0)1865 287721
— Reply to this email directly or view it on GitHub https://github.com/alimanfoo/anhima/pull/59#issuecomment-56553869.
Nicholas J Harding Principal Bioinformatician Global Health and Malaria Programme Kwiatkowski Group The Wellcome Trust Centre for Human Genetics Roosevelt Drive Oxford OX3 7BN United Kingdom
hardingnj
commented
10 years ago Done! Time to make change 1% Time to properly sync with upstream 99%...
On 23/09/14 18:03, Alistair Miles wrote:
Hi Nick, do you want to resubmit this as a new PR? Was a good idea.
On Thursday, September 18, 2014, hardingnj notifications@github.com wrote:
Closed #59 https://github.com/alimanfoo/anhima/pull/59.
Reply to this email directly or view it on GitHub https://github.com/alimanfoo/anhima/pull/59#event-167282977.
Alistair Miles Head of Epidemiological Informatics Centre for Genomics and Global Health http://cggh.org The Wellcome Trust Centre for Human Genetics Roosevelt Drive Oxford OX3 7BN United Kingdom Web: http://purl.org/net/aliman Email: alimanfoo@gmail.com Tel: +44 (0)1865 287721
— Reply to this email directly or view it on GitHub https://github.com/alimanfoo/anhima/pull/59#issuecomment-56553869.
Nicholas J Harding Principal Bioinformatician Global Health and Malaria Programme Kwiatkowski Group The Wellcome Trust Centre for Human Genetics Roosevelt Drive Oxford OX3 7BN United Kingdom
Had a case where passing in the string 'genotypes' failed in _loadregion, maybe we could have an automatic check for a list?
(rather than a list as expected) If a string ie 'str' implicitly converts to ['str']
looping though 's','t', 'r' causes failure