search

alimaye / sun-fan-delta-model

GNU General Public License v3.0
0 stars 0 forks source link

Question: where do these routing rules come from? #55

Closed amoodie closed 2 years ago

amoodie commented 3 years ago

Question: where do these routing rules come from?

https://github.com/alimaye/sun-fan-delta-model/blob/9f28ab89a1c52c24ef8e193910f3f5e75ab04796/source/routeFlow.m#L81-L86

These may be part of why our network is not as complex as Sun's (#53). For example, the moment slope down one branch is adverse, the branch is abandoned, because flow routed down that branch is 0 according to these rules.

These rules aren't explicit in Sun et al., did you take them from Murray and Paola?

I get that we can't just treat the negative slopes as normal, due to the ^0.5, but maybe there is another treatment we could use?

alimaye commented 3 years ago

That's correct. I didn't find a rule for adverse slopes, so I applied the rule from Murray and Paola (1994) as that paper is referenced implicitly and explicitly for the Sun model design (paragraphs 5, 17). An alternative could be to use this other rule from Murray and Paola (their Box 1) for the case with all adverse slopes. Perhaps it could be modified for case with mixed sign for slope?

image