Closed MaksHostroushko closed 1 year ago
Thank you.
I've removed code duplication, use loop instead until, fixed spaces and empty blanks.
In the classes I use the same methods, but each class has its own text and different emoji, they are not repeated. Also, not to repeat myself, used super
.
You did great! Let's add some changes
https://github.com/alinajuly/RubyHW/blob/main/HW3/tamagotchi_with_html_gem/pet.rb#L84..L88 In this case, you duplicated the code Just use
||
operator if you need to do something with multiple conditionsuntil pet_array.include?(pet_type) do
Please, try to don't useuntil
I believe, we can resolve it in a better wayPlease, fix all spaces and empty blanks according to code style
You have a lot of classes(for example, https://github.com/alinajuly/RubyHW/blob/main/HW3/tamagotchi_with_html_gem/dog.rb) where you have the same method Please, try to avoid duplicating