Favorite Function - Githubissues

alinarub / dog-app

Dog App created by Achim, Gregor and Alina.

https://dog-genie.com

2 stars 0 forks source link

Favorite Function #24

Open gregorsart opened 12 months ago

gregorsart commented 12 months ago

Value proposition

As a user I want to save my favorited dogs,

in order to create an individual collection.

Description

Acceptance criteria

[ ] By clicking the favorite button, the chosen dog is marked with a filled heart.
[ ] All favorited dogs are also shown on a separate favorite-dogs page.
[ ] You can toggle the favorite button on the favorite-dogs page as well as on the detail-page.
[ ] The favorite-dogs page is always reachable even if the app is reloaded.

Tasks

[ ] Create feature branch favorite-function-v2.
[ ] Create Favorite component.
[ ] Create favorite-dogs page.
[ ] Use local storage which contains all favorited dogs by the user.
[ ] Use AllDogsCard to display favorited dogs on the favorite-dogs page.

ykolomytseva commented 11 months ago

Hiiiii, @gregorsart @alinarub @AchimBartscht ! Great app so far, all dogs are cute. 🐕 Just a few suggestions for this user story from my team to make it a little clearer:

Value Proposition =>
As a user, I want to save my favorited dogs, In order to create an individual collection.
It would be cool, if you could add an extra image to show how your favorite-dogs page would look like
Maybe you could remove it at all or write it differently: The user can always go back to their favorited dogs, they are stored even if the browser closes => Favorite-dogs page is always reachable even by reloading the app
small tip: maybe you would consider to add a favorite button on All Dogs page, to make the process more user friendly and save time, so user won`t have to click on description and read details and then can do this later. 🐩

AchimBartscht commented 11 months ago

Hi Yana, thank you for reviewing. For now we have decided not to add a favorite button to the All Dogs Page. If we still have time later on, we might creagte another user story.

Philipp-Hess commented 11 months ago

Well done 👍 Looks good to me.

alinarub commented 11 months ago

We decided not to display hearts on the dog cards because they already link to the detail page. Also, we didn't add Favorites on the navigation menu because we built this on an older branch that still needed refactoring, we'll add it later. You can view the page by adding /favorite-dogs to the url.