alinebee / Boxer

The DOS game emulator that's fit for your Mac.
http://boxerapp.com/
769 stars 138 forks source link

Code cleanup: property attributes and manual property synthesis #78

Closed alinebee closed 6 years ago

alinebee commented 6 years ago

Based off https://github.com/alunbestor/Boxer/tree/64bit/master, which is a clone of https://github.com/MaddTheSane/Boxer/commit/234a6a7859ad2a2499eef59be345eacc7d5d79f8

This PR cleans up a swathe of classes to do the following:

This PR also clarifies a bunch of redundant or inappropriate @property attributes, according to the following rules:

Some classes with complex sets of ivars (e.g. BXSession and BXEmulator) have not yet been migrated, as they need additional work to expose necessary properties to subclasses/subcomponents. I have no doubt also missed a bunch of property attributes too.

alinebee commented 6 years ago

cc @MaddTheSane you've done a lot of cleanup work around property attributes - this integrates your latest changes, and I'd appreciate your eyes on this in case I've inadvertently regressed something.