search

alinebee / Boxer

The DOS game emulator that's fit for your Mac.
http://boxerapp.com/
769 stars 138 forks source link

Fix exception when awakening launch panel #80

Closed alinebee closed 6 years ago

alinebee commented 6 years ago

BXLaunchPanelController was setting its internal properties too late and triggering KVO too early in its lifecycle, triggering a collection view exception when opening a plain DOS window.

This may have been a regression from https://github.com/alunbestor/Boxer/pull/78, but since that PR did not touch the lines responsible I have no idea why it wasn't always crashing.

alinebee commented 6 years ago

Welp, that wasn't quite it. The regression specifically occurs in https://github.com/alunbestor/Boxer/commit/8900c0b17cf8d8f2e4216bde1d581daeac089d9a (thanks git bisect!), and while this PR fixed it for the basic DOS prompt, a similar exception occurs when opening a gamebox.

alinebee commented 6 years ago

This has since been fixed in https://github.com/alunbestor/Boxer/pull/81.