search

alinz / react-native-share-extension

react-native as an engine to drive share extension
MIT License
766 stars 401 forks source link

Crash in production... #23

Closed adrianotadao closed 7 years ago

adrianotadao commented 7 years ago

@alinz Hi man, sorry to bother you again.

Do you know or, have you heard someone talking about the crash when using Fastlane? I have added the script to build local on my device... at this point, everything is okay but, when I'm using Fastlane to deploy my app to the testers, the extension is not opening =l

What is the best way to debug it?

Ps. Odin, help me! 🙏 😂

adrianotadao commented 7 years ago

I'm so dumb. I can change the schema to use the release instead of debugging.

alinz commented 7 years ago

lol

npomfret commented 7 years ago

Did you find what was wrong? Mine is crashing when deployed through fastlane also

adrianotadao commented 7 years ago

@npomfret my problem was just a line that we forgot =l

I think that the problem was because we weren't registering the extension app on index.ios.js. But the guy who fixed that is @davidtstp...

@davidtstp do you have something to say about the problem? You know more than me what happened.

npomfret commented 7 years ago

Oh ok. My problem is that it works fine in dev. But when I send to fastlane it crashes. The UI appears but it looks like when calling ShareExtension.data() it fails. At least I don't see the shared data appearing on screen before the crash happens. Very strange.

adrianotadao commented 7 years ago

React native sometimes is sucks... it shows us generic errors. Another day I was receiving an error and when I decided to do a deep check I realized that the problem was inside the Intercom plugin. Always after this day, I check the libs almost before all.

Another big mistake that we stopped here is to add dependencies like. 'foo', '^1.0.1' ... we had a problem with the update of libs, so, nowadays we just put specific versions. Never more use '^1.0.1', we use just '1.0.1'.

npomfret commented 7 years ago

Agreed, never use wildcards in your dependencies - it's just madness.

I'm confident my libs are ok because it works when I run it outside of fastlane.

I even see the ui appear when running in fastlane... but no data and then a crash. I've added crashlytics but nothing still...

Having said all this, it could easily be my app crashing and not react-native-share-extension! I just can't tell cos there's no logging.

adrianotadao commented 7 years ago

hum... sorry man, I can't help you. There are a bunch of errors that I have no idea why. =l