Multiple data type - Githubissues

alinz / react-native-share-extension

react-native as an engine to drive share extension

MIT License

765 stars 401 forks source link

Multiple data type #45

Closed arribbar closed 7 years ago

arribbar commented 7 years ago

Add support for audio and video files
Get real path from downloaded content as whatsapp thanks to @cbjs.
Support multi files sharing thanks to @cbjs
Return now an array to android part

arribbar commented 7 years ago

Question: It seems indentation in JAVA part is a mess. What are the rules ? :)

alinz commented 7 years ago

@arribbar if you can use the Android Studio source formatter and send a PR i would merge it with code.

arribbar commented 7 years ago

@alinz Done! Thank you!

arribbar commented 7 years ago

@alinz Would it be possible to merge it ? (or tell me if anything is wrong ?)

arribbar commented 7 years ago

@alinz ?

alinz commented 7 years ago

@arribbar been a little bit busy with stuff, do we have this feature in iOS?

arribbar commented 7 years ago

We cannot get several medias with iOS but we can save video, images or text with iOS with what is done for now. I have a limited knowledge on iOS but I can work on this feature if you want to

alinz commented 7 years ago

@arribbar I'm gonna hold off on this, I want the api on both end be exactly the same on both platform. Need a little bit more time to rethink about it.

arribbar commented 7 years ago

All right. I am going to work on iOS side to be the same. I'll let you know when it is ready @alinz .