search

alinz / react-native-share-extension

react-native as an engine to drive share extension
MIT License
763 stars 398 forks source link

Multiple data type #84

Open arribbar opened 6 years ago

arribbar commented 6 years ago

iOS and Android

Android

arribbar commented 6 years ago

@alinz Do you have some time to take a look at this PR, please ? :)

pierretanguay commented 6 years ago

Works perfectly for me. Tried it in a live project.

abarisic86 commented 6 years ago

How can one extend this to accept application/octet? That should be similar to audio/video? @arribbar I'm trying to extend your PR with support for it but I have trouble starting the Sample Project. Another question, do we actually need android/src/main/java/com/github/... and child folders and files? It looks like duplicate old code.

kalek commented 6 years ago

@pierretanguay export chats from Whatsapp also works for you ?

arribbar commented 6 years ago

Oh, sorry @abarisic86, I haven't seen your message before. I'll try to take a look soon and make some corrections if needed

arribbar commented 5 years ago

@abarisic86 Do you still need help on this or not? I might have some time this weekend.

abarisic86 commented 5 years ago

hey, I couldn't set it up so I just discarded it, but thanks

On Thu, Sep 20, 2018 at 6:26 PM Bart Arribe notifications@github.com wrote:

@abarisic86 https://github.com/abarisic86 Do you still need help on this or not? I might have some time this weekend.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/alinz/react-native-share-extension/pull/84#issuecomment-423247179, or mute the thread https://github.com/notifications/unsubscribe-auth/AEuGE2_JpQlSqypm-CKPnL_-z6exa9LIks5uc8HPgaJpZM4SaIOm .

arribbar commented 5 years ago

Ok, sorry for my late response

AndrewHenderson commented 5 years ago

@arribbar If you want this merged, please resolve conflicts. Thanks!

arribbar commented 5 years ago

@AndrewHenderson done. Thank you :)

isaachinman commented 5 years ago

@AndrewHenderson I've been using this in a live project for several months now, but I suppose it still needs to get reviewed and put on the roadmap.

arribbar commented 5 years ago

Ok, I tested it a bit on Android. I made a fix to get images from whatsapp but I wonder if we shouldn't change getDataColumn function by adding a catch and use copyFile function if we are in the exception.

Link to getDataColumn : https://github.com/alinz/react-native-share-extension/pull/84/commits/90a6207a4fa7bbde7f8c1d1958d123e547544e7d#diff-5068d814d5a6c28612588fdf7b19debdR91

What do you think @AndrewHenderson ?

AndrewHenderson commented 5 years ago

@arribbar I'm testing this on a Samsung Galaxy S8 running Android v8.0. I'm finding that the sharing of images from Photos results in a value of null rather than a path to the image.

arribbar commented 5 years ago

Hmm, that's super strange. I am on a One Plus 5T on Android v8.1 and it works fine on my app. I checked it for one or several pictures as well as for videos on Photos, Gallery and Whatsapp

arribbar commented 5 years ago

@AndrewHenderson Can you provide me an example to test it ? I could not run the provided example by this project on Android :(

AndrewHenderson commented 5 years ago

@arribbar Thanks for providing device info.

I don't have a reduced test case I can send you. I'll work on getting the current example working or write a new one.

@isaachinman and I recently began assisting with the maintenance of this repo. Please bear with us as we get things moving smoothly again.

isaachinman commented 5 years ago

@AndrewHenderson Looks like the example hasn't been updated in a year. Any idea what it'll take to get that back up and running?

arribbar commented 5 years ago

@AndrewHenderson Can you provide me your running example ? I'll check the changes then that we need to do in order to make it work. Thanks !

arribbar commented 5 years ago

Ok, @AndrewHenderson. Can you try again now ? It should work better now I think

AndrewHenderson commented 5 years ago

Can you provide me an example to test it ? I could not run the provided example by this project on Android :(

@arribbar I restored the working example on the following branch: https://github.com/alinz/react-native-share-extension/tree/example/examples/simple.

It is boilerplate and runs on Android. In order to run on iOS one needs to follow the iOS Setup in order to manage code signing, etc.

If you still need the lightweight sample can use to validate the issue I mentioned, you can use that.

@isaachinman I wonder if there is a way we can have the iOS example run without all the added setup?

isaachinman commented 5 years ago

I wonder if there is a way we can have the iOS example run without all the added setup?

As far as I know, each of the steps are absolutely required. For iOS we are basically creating a "second" app entirely, so it's never going to be a quick process.

I am not an iOS dev by trade though - perhaps someone knows better than I.

arribbar commented 5 years ago

I'll take a look at this soon @AndrewHenderson Can you test with this last version ? I have made some improvements since you reviewed it and tell me if it is still not working for you or not :)

chaitanyadeorukhkar commented 5 years ago

Is this PR still active? How can I help to get this merged?

djorkaeffalexandre commented 5 years ago

@arribbar Do you plan fix that to merge? I want to use this library in my project on Google Summer of Code but I need support to multiple data.