search

alinz / react-native-webview-bridge

React Native Webview with Javascript Bridge
MIT License
1.37k stars 493 forks source link

Fixes #272: messages.forEach is not a function #273

Closed fungilation closed 5 years ago

fungilation commented 5 years ago

Fixes https://github.com/alinz/react-native-webview-bridge/issues/272

This is more of a bandaid. Should investigate how is messages getting malformed

chansuke commented 5 years ago

@fungilation Thx.I will check

fungilation commented 5 years ago

FYI, I've been committing multiple fixes to my fork, which all lumped into initial PR for fixing #272.

chansuke commented 5 years ago

Ok,I'll merge this then.Thank you for your work.

fungilation commented 5 years ago

Cool. I see a npm bump too (after 2 years!)

But what about the 5 changes/cleanup I suggested in review above?

chansuke commented 5 years ago

@fungilation Thanks for the confirmation and your feedbacks.

Well, I'm planning to merge these changes/cleanups in v0.40.1 and will release in next week.

Thanks so much for your work.