alinz / react-native-webview-bridge

React Native Webview with Javascript Bridge
MIT License
1.37k stars 493 forks source link

Clean up redundunt code #278

Closed chansuke closed 5 years ago

chansuke commented 5 years ago

@fungilation Oh, sorry I've rebased, but updated.

fungilation commented 5 years ago

Cool. When you can, the other 3 small changes I requested in https://github.com/alinz/react-native-webview-bridge/pull/273#pullrequestreview-159966511 so I can stop maintaining my fork and go back to yours please ;)

fungilation commented 5 years ago

These commits confuses me. var { PropTypes } = PropTypes was gone in index.android.js, but now it's back?

chansuke commented 5 years ago

Sorry, I deleted it too.

fungilation commented 5 years ago

Cool. Merge please