search

alinz / react-native-webview-bridge

React Native Webview with Javascript Bridge
MIT License
1.37k stars 493 forks source link

Use WebView from react-native-webview as it has been deprecated from … #289

Open cj3g10 opened 5 years ago

cj3g10 commented 5 years ago

Use WebView from react-native-webview as it has been deprecated from react-native and will be removed in future release.

See https://facebook.github.io/react-native/docs/webview for more info.

cj3g10 commented 5 years ago

Yes, I'm currently using this PR in my own app. I thought I turned off my formatting add-on, so I didn't realize index.ios.js had a lot of code re-ordering.

cj3g10 commented 5 years ago

One more thing: I think we will also need to add react-native link react-native-webview to the install instructions.

fungilation commented 5 years ago

One more thing: I think we will also need to add react-native link react-native-webview to the install instructions.

Yup. @chansuke merge please?

fungilation commented 5 years ago

@chansuke? Is no one maintaining this again?

I confirm this PR works perfectly in my app WonderSwipe, and is needed for RN 0.59.5. Please merge.

vendicto commented 5 years ago

@fungilation Could you merge it?

fungilation commented 5 years ago

Nope. No write access.

rosmcmahon commented 4 years ago

this still needs to be fixed