aliparlakci / bulk-downloader-for-reddit

Downloads and archives content from reddit
https://pypi.org/project/bdfr
GNU General Public License v3.0
2.26k stars 211 forks source link

[BUG] Development linting options for Ruff #937

Closed stared closed 5 months ago

stared commented 6 months ago

Description

Automatic tests fail, which is related to running Ruff linting with inappropriate arguments.

Command

First, related to format checking in .github/workflows/test.yml

Line

ruff check --format=github --select=E9,F63,F7,F82 .

Results in an error

error: unexpected argument '--format' found

  tip: to pass '--format' as a value, use '-- --format'

After fixing that we get

ruff check -- --format=github --select=E9,F63,F7,F82 .
ruff failed
  Cause: Failed to parse /Users/pmigdal/tmp/reddit/bulk-downloader-for-reddit/pyproject.toml
  Cause: TOML parse error at line 96, column 10
   |
96 | format = "grouped"
   |          ^^^^^^^^^
invalid type: string "grouped", expected struct FormatOptions

Environment (please complete the following information)