search

alipay / alipay-sdk-nodejs-all

支付宝开放平台 Alipay SDK for Node.js
https://docs.open.alipay.com/54/103419/
Other
407 stars 64 forks source link

Replaces deprecated request dependency #73

Closed perrin4869 closed 1 year ago

perrin4869 commented 4 years ago

I tried to leave everything backwards compatible. All the tests that were passing are still passing now. Since urllib is not required anymore because bent can do everything urllib can, I went ahead and removed it too. It should make this library much lighter for the end user, especially since urllib was a massive dependency, but here was only used to make simple http requests. This should also enable bundling this library with rollup, since it no longer depends on libraries that hold circular dependencies.

perrin4869 commented 2 years ago

@ottomao I resolved the conflicts and fixed the tests! Would be nice if you could review this, thanks!

troyeagle commented 1 year ago

Thanks a lot for your contribution and sorry for this late reply. We decide to use urllib as our http request library, because bent seems to be no longer maintained, and urllib is under our maintenance. The request dependency will be removed in #95 .