alipbcs / ZetaRay

Real-time Direct3D 12 path tracer
MIT License
223 stars 4 forks source link

Cornell Box scene dark & RenderDoc launch fails at Dx12 ray tracing feature tier 1.1 not supported #4

Open yhyu13 opened 1 year ago

yhyu13 commented 1 year ago

Hi,

I was running this project with latest commit 3c57d8166f7044eef7b151797508892714fab1ee

1, But I found that the already preprocessed gltf cornell box scene mentioned in the README fails to render with complete darkness

ZetaLab_tKwui433G2

2,

So I was trying to debug this scene with RenderDoc v1.28 (latest stable release), but when launching from renderdoc, I got this

ZetaLab_UramyqXOUY

Triggerd by this line of code

https://github.com/alipbcs/ZetaRay/blob/3c57d8166f7044eef7b151797508892714fab1ee/ZetaCore/Core/Device.cpp#L97

I tried to change it to,

Check(feature.RaytracingTier != D3D12_RAYTRACING_TIER_NOT_SUPPORTED, "Raytracing Tier not supported.");

and it still fails with renderdoc but pass the ordinary launch. I guess it is a problem regard to renderdoc not supporting dx12 raytracing? But I cannot find any solutions online.

I wonder what tools you used to debug shader in this case. I am pretty sure it is problem with ray tracing shaders but I am not sure where to start at this embarrassing moment.

My rig is RTX2080super desktop.

Thanks!

yhyu13 commented 1 year ago

Update:

Same Project works fine on my home latptop with RTX4060, I guess the problem is on my side either due driver setting or driver not updated.

ZetaLab_pKJUAOOFtX

alipbcs commented 1 year ago

Hi,

I was running this project with latest commit 3c57d8166f7044eef7b151797508892714fab1ee

1, But I found that the already preprocessed gltf cornell box scene mentioned in the README fails to render with complete darkness

ZetaLab_tKwui433G2

2,

So I was trying to debug this scene with RenderDoc v1.28 (latest stable release), but when launching from renderdoc, I got this

ZetaLab_UramyqXOUY

Triggerd by this line of code

https://github.com/alipbcs/ZetaRay/blob/3c57d8166f7044eef7b151797508892714fab1ee/ZetaCore/Core/Device.cpp#L97

I tried to change it to,

Check(feature.RaytracingTier != D3D12_RAYTRACING_TIER_NOT_SUPPORTED, "Raytracing Tier not supported.");

and it still fails with renderdoc but pass the ordinary launch. I guess it is a problem regard to renderdoc not supporting dx12 raytracing? But I cannot find any solutions online.

I wonder what tools you used to debug shader in this case. I am pretty sure it is problem with ray tracing shaders but I am not sure where to start at this embarrassing moment.

My rig is RTX2080super desktop.

Thanks!

RenderDoc doesn't support DXR, so it can't be used for debugging here.

I mainly used PIX and Nsight Graphics. Make sure the debug layer is disabled (ZetaCore/Core/Device.cpp, line 11) as it can sometimes cause problems with these tools.

alipbcs commented 1 year ago

Update:

Same Project works fine on my home latptop with RTX4060, I guess the problem is on my side either due driver setting or driver not updated.

ZetaLab_pKJUAOOFtX

Glad it's working! Here's something else to try: In the debug window, go to Settings -> Parameters -> Display -> Final Render—there, you can view various intermediate results (such as G-Buffers, raytraced lighting, etc). This should help you narrow down your search to identify the source of the problem.

Let me know if you figure out what's causing the issue on the RTX 2080 super system, I'm definitely curious!