Wrong configuration files in dependencies

alire-project / alire

Command-line tool from the Alire project and supporting library

GNU General Public License v3.0

288 stars 49 forks source link

Wrong configuration files in dependencies #1385

Closed reznikmm closed 1 year ago

reznikmm commented 1 year ago

The alr writes wrong configuration files for me in a dependencies (VSS). To reproduce:

alr index --add git+https://github.com/reznikmm/als-alire-index.git#v23.0.18 --name als
alr get ada_language_server
in ada_language_server_23.0.18_973e7d46/alire/cache/dependencies/vss_24.0.0_9d3df28c/config
- vss_config.gpr misses -gnat2022 as it requested in VSS alire.toml with
```
[build-switches]
"*".ada_version = "Ada2022"
```
- extra files vss_config.ads and vss_config.h - they are disabled in VSS alire.toml with
```
[configuration]
generate_ada = false
generate_c = false
```

mosteo commented 1 year ago

Which alr version is this? It could be related to #1355

reznikmm commented 1 year ago

alr 1.2.1

mosteo commented 1 year ago

OK, after closer inspection this isn't a bug. Alire relies on the manifest from the index, not the one that might be packaged with the sources (as otherwise crates could lie about what they're going to do once download, for example in actions). In fact, such a manifest is moved out of the way after deployment to <crate>/alire/alire.toml.upstream to avoid confusion about this.

So the problem is that the manifest at ~/.config/alire/indexes/als/repo/index/vs/vss/vss-24.0.0-20230529.toml doesn't contain the switches you mention.

Same goes for the configuration extra files.

reznikmm commented 1 year ago

Thank you @mosteo ! Now I see my mistake. I changed vss-24.0.0-20230529.toml and it works now :gem:

Sorry for the noise :pray: